| Message ID | 20210628085630.2081-1-david.plowman@raspberrypi.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hi everyone This seems to have become a rather forgotten patch set (also here: https://patchwork.libcamera.org/project/libcamera/list/?series=2183). In fact it's so old I'd managed to lose the original email that I sent! So I was wondering if I might give folks a little nudge for some thoughts on this. Thanks! David On Wed, 22 Sept 2021 at 13:27, Naushir Patuck <naush@raspberrypi.com> wrote: > > > > ---------- Forwarded message --------- > From: David Plowman <david.plowman@raspberrypi.com> > Date: Mon, 28 Jun 2021 at 09:56 > Subject: [libcamera-devel] [PATCH 0/2] Application support for per-mode sensitivities > To: <libcamera-devel@lists.libcamera.org> > > > Hi everyone > > Here's that potentially "missing piece" of support for per-mode > sensitivities. The question was how an application could get hold of > the selected mode's sensitivity before starting the camera, and > solution implemented here returns it in the CameraConfiguration > object. > > There are two patches, and they would need to be applied on top of the > first set of "per-mode sensitivities" patches. > > 1. The first patch merely adds a modeSensitivity field to the > CameraConfiguration and documents it. > > 2. The second patch returns the correct value from the Raspberry Pi > pipeline handler. I note that if CamHelpers move out of the IPA and > over to the pipeline handler, then this could become rather simpler. > > Thanks in advance for any feedback. > > Best regards > David > > David Plowman (2): > libcamera: camera: add a mode sensitivity field > libcamera: raspberrypi: fetch correct value for sensor's > modeSensitivity > > include/libcamera/camera.h | 2 ++ > include/libcamera/ipa/raspberrypi.mojom | 7 ++++++- > src/ipa/raspberrypi/raspberrypi.cpp | 7 +++++-- > src/libcamera/camera.cpp | 16 +++++++++++++++- > .../pipeline/raspberrypi/raspberrypi.cpp | 9 ++++++--- > 5 files changed, 34 insertions(+), 7 deletions(-) > > -- > 2.20.1 >
Hi everyone Here's that potentially "missing piece" of support for per-mode sensitivities. The question was how an application could get hold of the selected mode's sensitivity before starting the camera, and solution implemented here returns it in the CameraConfiguration object. There are two patches, and they would need to be applied on top of the first set of "per-mode sensitivities" patches. 1. The first patch merely adds a modeSensitivity field to the CameraConfiguration and documents it. 2. The second patch returns the correct value from the Raspberry Pi pipeline handler. I note that if CamHelpers move out of the IPA and over to the pipeline handler, then this could become rather simpler. Thanks in advance for any feedback. Best regards David David Plowman (2): libcamera: camera: add a mode sensitivity field libcamera: raspberrypi: fetch correct value for sensor's modeSensitivity include/libcamera/camera.h | 2 ++ include/libcamera/ipa/raspberrypi.mojom | 7 ++++++- src/ipa/raspberrypi/raspberrypi.cpp | 7 +++++-- src/libcamera/camera.cpp | 16 +++++++++++++++- .../pipeline/raspberrypi/raspberrypi.cpp | 9 ++++++--- 5 files changed, 34 insertions(+), 7 deletions(-)