Yeah, I know "5 files changed, 1245 insertions(+), 1159 deletions(-)" sounds
scary but it's mostly about moving stuff out from camera_device.cpp to a new
camera_capabilities.cpp.
What I mostly care about are coments on the interface between the 2 classes
(see the usage of capabilities_ in camera_device.cpp). The code has been moved
without modifications if not small changes to comments here and there, so that
part should be "easy" to review.
I think the new layout is not too bad. Also, controls and dynamic metadata
handling could then be moved to a new camera_controls.cpp which can be
initialized with the static information produced by CameraCapabilities.
What do you think ?
No regressions detected by running CTS with libcamera subplan (run 2 times in a
row) nor when testing with CCA.
Thanks
j
Jacopo Mondi (1):
android: Introduce CameraCapabilties class
src/android/camera_capabilities.cpp | 1165 +++++++++++++++++++++++++++
src/android/camera_capabilities.h | 64 ++
src/android/camera_device.cpp | 1147 +-------------------------
src/android/camera_device.h | 27 +-
src/android/meson.build | 1 +
5 files changed, 1245 insertions(+), 1159 deletions(-)
create mode 100644 src/android/camera_capabilities.cpp
create mode 100644 src/android/camera_capabilities.h
--
2.31.1