[libcamera-devel,v3,0/2] Raspberrypi: support per-mode camera sensitivities
mbox series

Message ID 20210611100703.2285-1-david.plowman@raspberrypi.com
Headers show
Series
  • Raspberrypi: support per-mode camera sensitivities
Related show

Message

David Plowman June 11, 2021, 10:07 a.m. UTC
Hi everyone

No functional changes here over v2, just re-submitting because there
were conflicts after the std::chrono::Duration changes in the AGC.

Comments eagerly anticipated, as always!

Thanks
David

David Plowman (2):
  ipa: raspberrypi: Add sensitivity field to camera mode
  ipa: raspberrypi: AGC: handle modes with different sensitivities

 src/ipa/raspberrypi/cam_helper.cpp           | 11 +++++++++
 src/ipa/raspberrypi/cam_helper.hpp           |  3 +++
 src/ipa/raspberrypi/controller/camera_mode.h |  2 ++
 src/ipa/raspberrypi/controller/rpi/agc.cpp   | 25 ++++++++++++++++----
 src/ipa/raspberrypi/controller/rpi/agc.hpp   |  1 +
 src/ipa/raspberrypi/raspberrypi.cpp          |  6 +++++
 6 files changed, 43 insertions(+), 5 deletions(-)

Comments

David Plowman June 21, 2021, 8:14 a.m. UTC | #1
Hi everyone

I was wondering if I might give this one a little prod?

When I originally posted this I asked for opinions on how we might
communicate mode sensitivities to an application, the difficulty being
that an application would, I expect, typically want to know it before
starting the camera. I think I proposed returning it in the
configuration. What do people think? Perhaps I'll put together another
patch which implements that.

Thanks
David

On Fri, 11 Jun 2021 at 11:07, David Plowman
<david.plowman@raspberrypi.com> wrote:
>
> Hi everyone
>
> No functional changes here over v2, just re-submitting because there
> were conflicts after the std::chrono::Duration changes in the AGC.
>
> Comments eagerly anticipated, as always!
>
> Thanks
> David
>
> David Plowman (2):
>   ipa: raspberrypi: Add sensitivity field to camera mode
>   ipa: raspberrypi: AGC: handle modes with different sensitivities
>
>  src/ipa/raspberrypi/cam_helper.cpp           | 11 +++++++++
>  src/ipa/raspberrypi/cam_helper.hpp           |  3 +++
>  src/ipa/raspberrypi/controller/camera_mode.h |  2 ++
>  src/ipa/raspberrypi/controller/rpi/agc.cpp   | 25 ++++++++++++++++----
>  src/ipa/raspberrypi/controller/rpi/agc.hpp   |  1 +
>  src/ipa/raspberrypi/raspberrypi.cpp          |  6 +++++
>  6 files changed, 43 insertions(+), 5 deletions(-)
>
> --
> 2.20.1
>