[libcamera-devel,0/2] Fix gcc warning in IPU3 pipeline handler
mbox series

Message ID 20210531020745.13815-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • Fix gcc warning in IPU3 pipeline handler
Related show

Message

Laurent Pinchart May 31, 2021, 2:07 a.m. UTC 
Hello,

This patch series fixes a gcc warning in the IPU3 pipeline handler.

The warning is described in both patches. I believe this to be a false
positive, but it still points to an issue in the code. Patch 1/2 fixes
the issue, which also gets rid of the warning. However, this modifies
the IPU3 BDS height calculation, which can result in unwanted side
effects (the code is quite fragile and very far from correct).

Patch 2/2 takes a different approach and just silences the warning,
leaving the incorrect BDS height calculation to be addressed later.

Only one of the two patches should be merged now. In addition to
reviewing the them, I'll thus ask you to vote for your favourite
candidate :-)

Laurent Pinchart (2):
  libcamera: pipeline: ipu3: Fix incorrect bdsHeight calculation
  libcamera: pipeline: ipu3: Fix warning when compiled with optimization

 src/libcamera/pipeline/ipu3/imgu.cpp | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)