[libcamera-devel,v6,0/3] libcamera: V4L2Device: VLA removal
mbox series

Message ID 20210426001220.15599-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • libcamera: V4L2Device: VLA removal
Related show

Message

Laurent Pinchart April 26, 2021, 12:12 a.m. UTC 
Hello,

This patch series is a part of the v5 of V4L2 device control
improvements posted by Hiro. I've split the VLA removal from the rest of
the series, in order to merge those fixes while continue the discussion
on the rest of the rework.

Patch 1/3 has seen the most extensive rework, as it was very intertwined
with 1/4 and 2/4 of v5. Patches 2/3 and 3/3 have just been rebased.
Hiro, could you please have a look ? If everything is fine to you I'll
merge the series. We can then discuss the rest of the changes rebased on
top.

Hirokazu Honda (3):
  libcamera: V4L2Device: Replace VLA with std::vector in getControls()
  libcamera: V4L2Device: Replace VLA with std::vector in setControls()
  libcamera: V4L2Device: Use Span in updateControls()

 include/libcamera/internal/v4l2_device.h |  4 +-
 src/libcamera/v4l2_device.cpp            | 73 +++++++++++-------------
 2 files changed, 36 insertions(+), 41 deletions(-)

Comments

Hirokazu Honda April 26, 2021, 2:02 a.m. UTC | #1 
Hi Laurent, thanks for the patches.

They look good to me.

On Mon, Apr 26, 2021 at 9:12 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hello,
>
> This patch series is a part of the v5 of V4L2 device control
> improvements posted by Hiro. I've split the VLA removal from the rest of
> the series, in order to merge those fixes while continue the discussion
> on the rest of the rework.
>
> Patch 1/3 has seen the most extensive rework, as it was very intertwined
> with 1/4 and 2/4 of v5. Patches 2/3 and 3/3 have just been rebased.
> Hiro, could you please have a look ? If everything is fine to you I'll
> merge the series. We can then discuss the rest of the changes rebased on
> top.
>
> Hirokazu Honda (3):
>   libcamera: V4L2Device: Replace VLA with std::vector in getControls()
>   libcamera: V4L2Device: Replace VLA with std::vector in setControls()
>   libcamera: V4L2Device: Use Span in updateControls()
>
>  include/libcamera/internal/v4l2_device.h |  4 +-
>  src/libcamera/v4l2_device.cpp            | 73 +++++++++++-------------
>  2 files changed, 36 insertions(+), 41 deletions(-)
>
> --
> Regards,
>
> Laurent Pinchart
>
Jacopo Mondi April 26, 2021, 10:29 a.m. UTC | #2 
Hello,

On Mon, Apr 26, 2021 at 03:12:17AM +0300, Laurent Pinchart wrote:
> Hello,
>
> This patch series is a part of the v5 of V4L2 device control
> improvements posted by Hiro. I've split the VLA removal from the rest of
> the series, in order to merge those fixes while continue the discussion
> on the rest of the rework.
>
> Patch 1/3 has seen the most extensive rework, as it was very intertwined
> with 1/4 and 2/4 of v5. Patches 2/3 and 3/3 have just been rebased.
> Hiro, could you please have a look ? If everything is fine to you I'll
> merge the series. We can then discuss the rest of the changes rebased on
> top.
>
> Hirokazu Honda (3):
>   libcamera: V4L2Device: Replace VLA with std::vector in getControls()
>   libcamera: V4L2Device: Replace VLA with std::vector in setControls()
>   libcamera: V4L2Device: Use Span in updateControls()

All patches looks good and all tests are passed

Tested-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
  j

>
>  include/libcamera/internal/v4l2_device.h |  4 +-
>  src/libcamera/v4l2_device.cpp            | 73 +++++++++++-------------
>  2 files changed, 36 insertions(+), 41 deletions(-)
>
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel