[libcamera-devel,v2,0/2] Fix support for core.mojom structs
mbox series

Message ID 20210422080816.364948-1-paul.elder@ideasonboard.com
Headers show
Series
  • Fix support for core.mojom structs
Related show

Message

Paul Elder April 22, 2021, 8:08 a.m. UTC 
This patch series fixes support for structs defined in core.mojom with
skipHeader only.

Previously these structs were only supported (tested) for use in custom
function parameters, but not as members of other structs. This patch
series fixed that.

Paul Elder (2):
  utils: ipc: Support types defined in core.mojom with skipHeader only
  utils: ipc: Include instead of forward-declare CameraSensorInfo

 include/libcamera/ipa/ipa_interface.h         |  6 +--
 .../module_ipa_serializer.h.tmpl              |  6 +++
 .../libcamera_templates/serializer.tmpl       | 38 +++++++++----------
 3 files changed, 27 insertions(+), 23 deletions(-)

Comments

Umang Jain April 22, 2021, 8:36 a.m. UTC | #1 
Hi Paul,

On 4/22/21 1:38 PM, Paul Elder wrote:
> This patch series fixes support for structs defined in core.mojom with
> skipHeader only.
>
> Previously these structs were only supported (tested) for use in custom
> function parameters, but not as members of other structs. This patch
> series fixed that.
>
> Paul Elder (2):
>    utils: ipc: Support types defined in core.mojom with skipHeader only
>    utils: ipc: Include instead of forward-declare CameraSensorInfo
>
>   include/libcamera/ipa/ipa_interface.h         |  6 +--
>   .../module_ipa_serializer.h.tmpl              |  6 +++
>   .../libcamera_templates/serializer.tmpl       | 38 +++++++++----------
>   3 files changed, 27 insertions(+), 23 deletions(-)
>
Yes, this version works as expected.

Tested-by: Umang Jain <umang.jain@ideasonboard.com>