[libcamera-devel,v6,0/5] android: Introduce HAL configuration file
mbox series

Message ID 20210415135213.94511-1-jacopo@jmondi.org
Headers show
Series
  • android: Introduce HAL configuration file
Related show

Message

Jacopo Mondi April 15, 2021, 1:52 p.m. UTC 
A new iteration to address Laurent's and Kieran's comments:
- Configuration:
  - call open() (now parseConfigurationFile()) at construction time
  - s/Fatal/Error
  - search configuration file only in sysconfdir
  - s/CameraProps/CameraConfigData/
  - s/valid/isValid()

- Integration
  - Take Laurent's suggestion in in camera_hal_manager.cpp
  - Drop default = nullptr in CameraDevice::initialize()

=== I have not run this version === (I'm physically away from Soraka today)
The only thing that can fail compared to previous version is the path lookup.

I'm sending it out anyway, mostly to comment on patch 6/6... will follow up
there...

Thanks
   j

Jacopo Mondi (4):
  libcamera: List dependency for Android Camera3 HAL
  android: Add CameraHalConfig class
  android: camera_device: Get properties from configuration
  android: soraka: Add camera HAL configuration

Kieran Bingham (1):
  src: meson: Define system paths

 README.rst                              |   3 +
 src/android/camera_device.cpp           |  56 +++-
 src/android/camera_device.h             |   3 +-
 src/android/camera_hal_config.cpp       | 400 ++++++++++++++++++++++++
 src/android/camera_hal_config.h         |  40 +++
 src/android/camera_hal_manager.cpp      |  33 +-
 src/android/camera_hal_manager.h        |   3 +
 src/android/data/soraka/camera_hal.yaml |   8 +
 src/android/meson.build                 |   2 +
 src/ipa/meson.build                     |  17 +-
 src/meson.build                         |   9 +
 11 files changed, 557 insertions(+), 17 deletions(-)
 create mode 100644 src/android/camera_hal_config.cpp
 create mode 100644 src/android/camera_hal_config.h
 create mode 100644 src/android/data/soraka/camera_hal.yaml

--
2.31.1