[libcamera-devel,0/2] libcamera: log: Small improvements
mbox series

Message ID 20210413215121.15538-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • libcamera: log: Small improvements
Related show

Message

Laurent Pinchart April 13, 2021, 9:51 p.m. UTC 
Hello,

This small patch series is a drive-by change the improves the logging
implementation a little bit.

I was hoping that builtins could give us pretty function names, but
that's not the case, so I'm not entirely sure that 2/2 is worth it.

Laurent Pinchart (2):
  libcamera: log: De-duplicate _log() functions and LogMessage
    constructor
  libcamera: log: Use compiler builtins to retrieve file and line number

 include/libcamera/internal/log.h | 20 ++++-----
 src/libcamera/log.cpp            | 75 +++++---------------------------
 2 files changed, 20 insertions(+), 75 deletions(-)

Comments

Sebastian Fricke April 14, 2021, 3:37 a.m. UTC | #1 
Hey Laurent,

On 14.04.2021 00:51, Laurent Pinchart wrote:
>Hello,
>
>This small patch series is a drive-by change the improves the logging

s/ the improves/, that improves/

>implementation a little bit.
>
>I was hoping that builtins could give us pretty function names, but
>that's not the case, so I'm not entirely sure that 2/2 is worth it.
>
>Laurent Pinchart (2):
>  libcamera: log: De-duplicate _log() functions and LogMessage
>    constructor
>  libcamera: log: Use compiler builtins to retrieve file and line number
>
> include/libcamera/internal/log.h | 20 ++++-----
> src/libcamera/log.cpp            | 75 +++++---------------------------
> 2 files changed, 20 insertions(+), 75 deletions(-)
>
>-- 
>Regards,
>
>Laurent Pinchart
>
>_______________________________________________
>libcamera-devel mailing list
>libcamera-devel@lists.libcamera.org
>https://lists.libcamera.org/listinfo/libcamera-devel