[libcamera-devel,0/5] test: v4l2_device: Cleanups and a small speed increase
mbox series

Message ID 20190508165814.26201-1-niklas.soderlund@ragnatech.se
Headers show
Series
  • test: v4l2_device: Cleanups and a small speed increase
Related show

Message

Niklas Söderlund May 8, 2019, 4:58 p.m. UTC
Hi,

This series started as an itch to speed up the tests as I run them quiet 
often and find them useful, and resulted in a bit of a clean up as well.  
It depends on [1].

With this applied I shave almost 7 seconds of the v4l2 device tests 
which is nice!

1. [PATCH v2 00/11] libcamerea: Add support for exclusive access to 
   cameras between processes

Niklas Söderlund (5):
  test: v4l2_device: Order class sections
  test: v4l2_device: Implement functions inside class definition in cpp
    files
  test: v4l2_device: Allow each test to specify which device and entity
    to test
  test: v4l2_device: Reset media links and set a resolution
  test: v4l2_device: Switch most tests to vimc

 test/v4l2_device/buffer_sharing.cpp   | 21 +++++----
 test/v4l2_device/capture_async.cpp    |  2 +-
 test/v4l2_device/double_open.cpp      |  3 ++
 test/v4l2_device/formats.cpp          | 61 ++++++++++++++-------------
 test/v4l2_device/request_buffers.cpp  |  4 ++
 test/v4l2_device/stream_on_off.cpp    |  3 ++
 test/v4l2_device/v4l2_device_test.cpp | 25 +++++++++--
 test/v4l2_device/v4l2_device_test.h   |  6 ++-
 8 files changed, 77 insertions(+), 48 deletions(-)

Comments

Kieran Bingham May 9, 2019, 8:34 a.m. UTC | #1
Hi Niklas,

On 08/05/2019 17:58, Niklas Söderlund wrote:
> Hi,
> 
> This series started as an itch to speed up the tests as I run them quiet 
> often and find them useful, and resulted in a bit of a clean up as well.  
> It depends on [1].
> 
> With this applied I shave almost 7 seconds of the v4l2 device tests 
> which is nice!

\o/ Ship it... wait - you didn't just remove the tests did you ? :-D

> 
> 1. [PATCH v2 00/11] libcamerea: Add support for exclusive access to 
>    cameras between processes
> 
> Niklas Söderlund (5):
>   test: v4l2_device: Order class sections
>   test: v4l2_device: Implement functions inside class definition in cpp
>     files
>   test: v4l2_device: Allow each test to specify which device and entity
>     to test
>   test: v4l2_device: Reset media links and set a resolution
>   test: v4l2_device: Switch most tests to vimc
> 
>  test/v4l2_device/buffer_sharing.cpp   | 21 +++++----
>  test/v4l2_device/capture_async.cpp    |  2 +-
>  test/v4l2_device/double_open.cpp      |  3 ++
>  test/v4l2_device/formats.cpp          | 61 ++++++++++++++-------------
>  test/v4l2_device/request_buffers.cpp  |  4 ++
>  test/v4l2_device/stream_on_off.cpp    |  3 ++
>  test/v4l2_device/v4l2_device_test.cpp | 25 +++++++++--
>  test/v4l2_device/v4l2_device_test.h   |  6 ++-
>  8 files changed, 77 insertions(+), 48 deletions(-)
>
Niklas Söderlund May 9, 2019, 8:43 a.m. UTC | #2
Hi Kieran,

On 2019-05-09 09:34:44 +0100, Kieran Bingham wrote:
> Hi Niklas,
> 
> On 08/05/2019 17:58, Niklas Söderlund wrote:
> > Hi,
> > 
> > This series started as an itch to speed up the tests as I run them quiet 
> > often and find them useful, and resulted in a bit of a clean up as well.  
> > It depends on [1].
> > 
> > With this applied I shave almost 7 seconds of the v4l2 device tests 
> > which is nice!
> 
> \o/ Ship it... wait - you didn't just remove the tests did you ? :-D

Why yes! It solved two of my issues, now the test suite runs faster 
_and_ my code no longer fails ;-)

> 
> > 
> > 1. [PATCH v2 00/11] libcamerea: Add support for exclusive access to 
> >    cameras between processes
> > 
> > Niklas Söderlund (5):
> >   test: v4l2_device: Order class sections
> >   test: v4l2_device: Implement functions inside class definition in cpp
> >     files
> >   test: v4l2_device: Allow each test to specify which device and entity
> >     to test
> >   test: v4l2_device: Reset media links and set a resolution
> >   test: v4l2_device: Switch most tests to vimc
> > 
> >  test/v4l2_device/buffer_sharing.cpp   | 21 +++++----
> >  test/v4l2_device/capture_async.cpp    |  2 +-
> >  test/v4l2_device/double_open.cpp      |  3 ++
> >  test/v4l2_device/formats.cpp          | 61 ++++++++++++++-------------
> >  test/v4l2_device/request_buffers.cpp  |  4 ++
> >  test/v4l2_device/stream_on_off.cpp    |  3 ++
> >  test/v4l2_device/v4l2_device_test.cpp | 25 +++++++++--
> >  test/v4l2_device/v4l2_device_test.h   |  6 ++-
> >  8 files changed, 77 insertions(+), 48 deletions(-)
> > 
> 
> -- 
> Regards
> --
> Kieran