[libcamera-devel,v2,0/3] Add RequestError to Request::Status
mbox series

Message ID 20210329091552.157208-1-hiroh@chromium.org
Headers show
Series
  • Add RequestError to Request::Status
Related show

Message

Hirokazu Honda March 29, 2021, 9:15 a.m. UTC 
PipelineHandler doesn't notify a client an error during
processing a capture request. This addresses the issue by adding
the new enum value to Request::Status, so that each Camera client
can know whether the error happens by Request::status().

Change in v2:
- Adopt adding RequestError to Request::Status rather than adding an error code to Request
- Handle RequestCancelled and RequestError differently in a request completion.

Hirokazu Honda (3):
  libcamera: PipelineHandler: Make queueRequest() void function
  libcamera: Request: Add RequestError to Status
  Regard a request error in the request completion

 Documentation/guides/application-developer.rst |  2 ++
 include/libcamera/internal/pipeline_handler.h  |  2 +-
 include/libcamera/request.h                    |  2 ++
 src/cam/capture.cpp                            |  5 +++++
 src/gstreamer/gstlibcamerasrc.cpp              |  6 +++++-
 src/libcamera/camera.cpp                       |  6 ++++--
 src/libcamera/pipeline_handler.cpp             | 11 +++++------
 src/libcamera/request.cpp                      | 17 +++++++++++------
 src/qcam/main_window.cpp                       |  4 ++++
 src/v4l2/v4l2_camera.cpp                       |  5 +++++
 10 files changed, 44 insertions(+), 16 deletions(-)

--
2.31.0.291.g576ba9dcdaf-goog