[libcamera-devel,RFC,0/2] Enable handling a number of capture requests
mbox series

Message ID 20210329022604.110201-1-hiroh@chromium.org
Headers show
Series
  • Enable handling a number of capture requests
Related show

Message

Hirokazu Honda March 29, 2021, 2:26 a.m. UTC 
Originally PipelineHandler discards capture requests if queueing
fails with any reason. If a client queues a number of capture
requests for short time, queueing tends to fail due to a buffer
shortage. In the case PipelineHandler should rather retry to
queue capture requests later.
This patch series enables PipelineHandler to handle a number of
capture requests by storing them on a buffer shortage failure and
retrying to queue later.

Hirokazu Honda (2):
  libcamera: CameraData: Change queuedRequests_ type to std::dequeue
  libcamera: PipelineHandler: Retry queuing a capture request

 include/libcamera/internal/pipeline_handler.h |  6 +-
 src/libcamera/pipeline_handler.cpp            | 61 ++++++++++++++++---
 2 files changed, 58 insertions(+), 9 deletions(-)

--
2.31.0.291.g576ba9dcdaf-goog

Comments

Sebastian Fricke March 29, 2021, 5:31 a.m. UTC | #1 
Hey Hirokazu,

On 29.03.2021 11:26, Hirokazu Honda wrote:
>Originally PipelineHandler discards capture requests if queueing
>fails with any reason. If a client queues a number of capture
>requests for short time, queueing tends to fail due to a buffer

s/for short time/for a short time/

>shortage. In the case PipelineHandler should rather retry to

s/In the case/In that case/

>queue capture requests later.
>This patch series enables PipelineHandler to handle a number of
>capture requests by storing them on a buffer shortage failure and

s/on a/in case of a/

>retrying to queue later.

Greetings,
Sebastian

>
>Hirokazu Honda (2):
>  libcamera: CameraData: Change queuedRequests_ type to std::dequeue
>  libcamera: PipelineHandler: Retry queuing a capture request
>
> include/libcamera/internal/pipeline_handler.h |  6 +-
> src/libcamera/pipeline_handler.cpp            | 61 ++++++++++++++++---
> 2 files changed, 58 insertions(+), 9 deletions(-)
>
>--
>2.31.0.291.g576ba9dcdaf-goog
>_______________________________________________
>libcamera-devel mailing list
>libcamera-devel@lists.libcamera.org
>https://lists.libcamera.org/listinfo/libcamera-devel