[libcamera-devel,0/2] libcamera: Do not default the location property
mbox series

Message ID 20210318125521.43278-1-jacopo@jmondi.org
Headers show
Series
  • libcamera: Do not default the location property
Related show

Message

Jacopo Mondi March 18, 2021, 12:55 p.m. UTC 
Hello,
   we've been discussion about how to handle the camera location
properly in libcamera and Android HAL.

The current setup
- defaults location to External in libcamera if the fw does not provide that
- sets FRONT if location is External in Android Camera HAL

This will make very complex to discern in future if a camera is actually
external once the camera HAL will support the EXTERNAL HW level.

To simplify this and make it easier to fallback to a getting location from
a configuration file in the Camera HAL:
- Do not report property::Location in libcamera if not available in fw
- Do not default External to FRONT in HAL
- To maintain compatibility with Android set location to FRONT if not available
  from the library in the Camera HAL.

No regressions in CTS testing.

Thanks
   j

Jacopo Mondi (2):
  libcamera: camera_sensor: Do not register Location if not available
  android: camera_device: Do not default External to Front

 src/android/camera_device.cpp   | 6 +-----
 src/libcamera/camera_sensor.cpp | 6 ++----
 2 files changed, 3 insertions(+), 9 deletions(-)

--
2.30.0