[libcamera-devel,0/7] Raspberry Pi: ipa::init() restructuring
mbox series

Message ID 20210317100211.1067585-1-naush@raspberrypi.com
Headers show
Series
  • Raspberry Pi: ipa::init() restructuring
Related show

Message

Naushir Patuck March 17, 2021, 10:02 a.m. UTC 
Hi,

This series uses Paul's recent work and moves some initialisation code from ipa::configure()
into ipa::init().  As a consequence, the pipeline handler is now able to selectively open
the Unicam embedded data node in pipeline_handler::match(), removing some of the existing
ugliness in dealing with opening this node.

Brief patch breakdown:

Patch 1/7: Adds the sensor model string to IPASettings.
Patch 2/7: Moves the CamHelper initialise to ipa::init().
Patch 3/7: Conditionally open the embedded data node in pipeline_handler::match().
Patch 4/7: Move controller initialise to ipa::init().
Patches 5/7 - 7/7: Some tidy-ups (remove unused member variables, some renaming) after the above refactoring.

Thanks,
Naush

Naushir Patuck (7):
  ipa: Add sensor model string to IPASettings
  pipeline: ipa: raspberrypi: Open the CamHelper on ipa::init()
  pipeline: raspberrypi: Conditionally open the embedded data node
  ipa: raspberrypi: Move the controller initialise to ipa::init()
  ipa: raspberrypi: Remove unused member variables
  ipa: raspberrypi: Rationalise parameters to ipa::start()
  ipa: raspberrypi: Rationalise parameters to ipa::configure()

 include/libcamera/ipa/core.mojom              |   8 ++
 include/libcamera/ipa/raspberrypi.mojom       |  27 ++--
 src/ipa/raspberrypi/raspberrypi.cpp           | 110 +++++++--------
 .../pipeline/raspberrypi/raspberrypi.cpp      | 128 ++++++++----------
 src/libcamera/pipeline/vimc/vimc.cpp          |   2 +-
 test/ipa/ipa_interface_test.cpp               |   2 +-
 6 files changed, 119 insertions(+), 158 deletions(-)

Comments

David Plowman March 22, 2021, 8:56 a.m. UTC | #1 
Hi Naush

Thanks for all these patches. I did have a look through them but
didn't really have anything significant to comment on. However, can I
please add

Tested-by: David Plowman <david.plowman@raspberrypi.com>

for the whole set?

Thanks!
David

On Wed, 17 Mar 2021 at 10:02, Naushir Patuck <naush@raspberrypi.com> wrote:
>
> Hi,
>
> This series uses Paul's recent work and moves some initialisation code from ipa::configure()
> into ipa::init().  As a consequence, the pipeline handler is now able to selectively open
> the Unicam embedded data node in pipeline_handler::match(), removing some of the existing
> ugliness in dealing with opening this node.
>
> Brief patch breakdown:
>
> Patch 1/7: Adds the sensor model string to IPASettings.
> Patch 2/7: Moves the CamHelper initialise to ipa::init().
> Patch 3/7: Conditionally open the embedded data node in pipeline_handler::match().
> Patch 4/7: Move controller initialise to ipa::init().
> Patches 5/7 - 7/7: Some tidy-ups (remove unused member variables, some renaming) after the above refactoring.
>
> Thanks,
> Naush
>
> Naushir Patuck (7):
>   ipa: Add sensor model string to IPASettings
>   pipeline: ipa: raspberrypi: Open the CamHelper on ipa::init()
>   pipeline: raspberrypi: Conditionally open the embedded data node
>   ipa: raspberrypi: Move the controller initialise to ipa::init()
>   ipa: raspberrypi: Remove unused member variables
>   ipa: raspberrypi: Rationalise parameters to ipa::start()
>   ipa: raspberrypi: Rationalise parameters to ipa::configure()
>
>  include/libcamera/ipa/core.mojom              |   8 ++
>  include/libcamera/ipa/raspberrypi.mojom       |  27 ++--
>  src/ipa/raspberrypi/raspberrypi.cpp           | 110 +++++++--------
>  .../pipeline/raspberrypi/raspberrypi.cpp      | 128 ++++++++----------
>  src/libcamera/pipeline/vimc/vimc.cpp          |   2 +-
>  test/ipa/ipa_interface_test.cpp               |   2 +-
>  6 files changed, 119 insertions(+), 158 deletions(-)
>
> --
> 2.25.1
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel