[libcamera-devel,v3,0/3] rkisp1: add an initial support to different hw revision
mbox series

Message ID 20210309063829.8710-1-dafna.hirschfeld@collabora.com
Headers show
Series
  • rkisp1: add an initial support to different hw revision
Related show

Message

Dafna Hirschfeld March 9, 2021, 6:38 a.m. UTC 
In kernel v5.11 the rkisp1 uapi had changed to support
different hardware versions. See [1].
Currently only version 10 is supported, therefore the IPA
should fail on 'init' if the revision is not 10.
In the future we want to add support for version V12.
See revisions documentation at [2].

Changes from v1:
- compilation fix in patch 3 that I forgot to update in first version
- typo fixes
- in patch 2, if 'configure' of the rkisp1 IPA fails return -EINVAL
- in patch 3, if hw revision is not supported, return -ENODEV

Changes from v2:
- in patch 1: add doxygen documentation for the new function hwRevision
- in patch 2: small typo fix
- in patch 3:
* the revision check is moved from the function 'configure' to the function 'init'.
* remove uapi header update and support for v10 since it is already done in a different patchset

Dafna Hirschfeld (3):
  libcamera: media_device: add hwRevision method
  src: rkisp1: return error from ipa's configure method if it fails
  ipa: rkisp1: fail on init if hw revision is not RKISP1_V10

 include/libcamera/internal/media_device.h |  2 ++
 include/libcamera/ipa/rkisp1.mojom        |  4 ++--
 src/ipa/rkisp1/rkisp1.cpp                 | 28 +++++++++++++++--------
 src/libcamera/media_device.cpp            | 10 ++++++++
 src/libcamera/pipeline/rkisp1/rkisp1.cpp  | 17 +++++++-------
 5 files changed, 42 insertions(+), 19 deletions(-)