[libcamera-devel,v2,0/2] Fix camera location
mbox series

Message ID 20210222080112.72521-1-paul.elder@ideasonboard.com
Headers show
Series
  • Fix camera location
Related show

Message

Paul Elder Feb. 22, 2021, 8:01 a.m. UTC 
libcamera defaults the location of cameras with no V4L2 camera
orientation control to external.

Our android HAL implementation currently doesn't support external
cameras, so the CTS test
"android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList"
will fail when cameras have a location of external.

The long-term solution is to make sure that the orientation is declared
in the firmware. In the meantime, this patch series makes libcamera
print a warning when the location is defaulted to external, and makes
the HAL implementation change it to front.

Paul Elder (2):
  libcamera: camera_sensor: Print warning when orientation is unknown
  android: camera_device: Set the camera location to Front if External

 src/android/camera_device.cpp   | 6 +++++-
 src/libcamera/camera_sensor.cpp | 6 ++++++
 2 files changed, 11 insertions(+), 1 deletion(-)