[libcamera-devel,0/2] Raspberry Pi IPA maintenance (final part)
mbox series

Message ID 20210208094036.6846-1-david.plowman@raspberrypi.com
Headers show
Series
  • Raspberry Pi IPA maintenance (final part)
Related show

Message

David Plowman Feb. 8, 2021, 9:40 a.m. UTC 
Hi

This small pair of patches is actually the final commit from my
previous "Raspberry Pi IPA maintenance" set, now broken up into 2
separate commits. (The other commits have already been merged - thank
you!)

The first should be uncontroverisal, I hope, and the second is the one
that removes libatomic from the build dependencies - we can think
about what we want to do with that one!

Best regards
David

David Plowman (2):
  ipa: raspberrypi: Remove atomic variable from Algorithm class
  ipa: raspberrypi: Remove libatomic from build dependencies

 src/ipa/raspberrypi/controller/algorithm.hpp | 3 +--
 src/ipa/raspberrypi/meson.build              | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)

Comments

Laurent Pinchart Feb. 8, 2021, 4:17 p.m. UTC | #1 
Hi David,

Thank you for the patch.

On Mon, Feb 08, 2021 at 09:40:36AM +0000, David Plowman wrote:
> With all the atomic variables removed from the Raspberry Pi control
> algorithms, libatomic is no longer required.
> 
> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
> ---
>  src/ipa/raspberrypi/meson.build | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build
> index 9445cd09..4cdd0434 100644
> --- a/src/ipa/raspberrypi/meson.build
> +++ b/src/ipa/raspberrypi/meson.build
> @@ -5,7 +5,6 @@ ipa_name = 'ipa_rpi'
>  rpi_ipa_deps = [
>      libcamera_dep,
>      dependency('boost'),
> -    libatomic,

As mentioned in the previous version, I'm a bit cautious about this
change, because I don't fully understand the need to link to libatomic
on some platforms. I believe it should be safe, so I'm willing to give
it a try.

Kieran, I think the issue was initially reported by builroot, when
compiling on sparc. Do we have an easy way to test this ?

>  ]
>  
>  rpi_ipa_includes = [