[libcamera-devel,0/2] libcamera: Add support for RGB565X format
mbox series

Message ID 20210131184352.10635-1-laurent.pinchart@ideasonboard.com
Headers show
Series
  • libcamera: Add support for RGB565X format
Related show

Message

Laurent Pinchart Jan. 31, 2021, 6:43 p.m. UTC 
Hello,

The V4L2 RGB565X format maps to DRM to the big-endian version of
DRM_FORMAT_RGB565. libcamera doesn't support big-endian DRM formats yet,
so patch 1/2 addresses this issue in the gen-formats.py script. Patch
2/2 then adds support for the format.

Laurent Pinchart (2):
  utils: gen-formats: Support big-endian DRM formats
  libcamera: formats: Add RGB565_BE format

 src/libcamera/formats.cpp          | 10 ++++++++++
 src/libcamera/formats.yaml         |  3 +++
 src/libcamera/v4l2_pixelformat.cpp |  1 +
 utils/gen-formats.py               |  5 ++++-
 4 files changed, 18 insertions(+), 1 deletion(-)

Comments

Jacopo Mondi Feb. 1, 2021, 10:33 a.m. UTC | #1 
Hi Laurent,

On Sun, Jan 31, 2021 at 08:43:50PM +0200, Laurent Pinchart wrote:
> Hello,
>
> The V4L2 RGB565X format maps to DRM to the big-endian version of
> DRM_FORMAT_RGB565. libcamera doesn't support big-endian DRM formats yet,
> so patch 1/2 addresses this issue in the gen-formats.py script. Patch
> 2/2 then adds support for the format.
>
> Laurent Pinchart (2):
>   utils: gen-formats: Support big-endian DRM formats
>   libcamera: formats: Add RGB565_BE format

Both patches look good!
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
  j

>
>  src/libcamera/formats.cpp          | 10 ++++++++++
>  src/libcamera/formats.yaml         |  3 +++
>  src/libcamera/v4l2_pixelformat.cpp |  1 +
>  utils/gen-formats.py               |  5 ++++-
>  4 files changed, 18 insertions(+), 1 deletion(-)
>
> --
> Regards,
>
> Laurent Pinchart
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel