| Message ID | 20210129111616.1047483-1-naush@raspberrypi.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hi all, On Fri, 29 Jan 2021 at 11:16, Naushir Patuck <naush@raspberrypi.com> wrote: > Hi, > > Here is the next revision of the patch series. The only difference > between this > and v3 is a change to the comment text as suggested by Laurent in patch > 2/5. > > With the recent merge of DelayedCtrls, patch 5/5 in this series is now redundant. All other patches still remain unchanged and can be merged without patch 5/5 for this work. As discussed with Niklas, I will work to port the changes from patch 5/5 into DelayedCtrls at some point in the near future. Regards, Naush > Jacopo Mondi (1): > libcamera: camera_sensor: Make VBLANK mandatory > > Naushir Patuck (4): > libcamera: camera_sensor: Add frame length limits to CameraSensorInfo > ipa: raspberrypi: Limit the calculated vblank based on the sensor mode > ipa: raspberrypi: Pass the maximum allowable shutter speed into the > AGC > pipeline: raspberrypi: Add notion of priority write to StaggeredCtrl > > Documentation/sensor_driver_requirements.rst | 6 +- > include/libcamera/internal/camera_sensor.h | 3 + > src/ipa/raspberrypi/cam_helper.cpp | 16 ++--- > src/ipa/raspberrypi/cam_helper.hpp | 5 +- > src/ipa/raspberrypi/cam_helper_imx219.cpp | 6 +- > src/ipa/raspberrypi/cam_helper_imx477.cpp | 4 +- > src/ipa/raspberrypi/cam_helper_ov5647.cpp | 4 +- > .../raspberrypi/controller/agc_algorithm.hpp | 1 + > src/ipa/raspberrypi/controller/camera_mode.h | 2 + > src/ipa/raspberrypi/controller/rpi/agc.cpp | 48 +++++++++----- > src/ipa/raspberrypi/controller/rpi/agc.hpp | 3 + > src/ipa/raspberrypi/raspberrypi.cpp | 66 ++++++++++++++----- > src/libcamera/camera_sensor.cpp | 44 +++++++++++-- > .../pipeline/raspberrypi/raspberrypi.cpp | 12 +++- > .../pipeline/raspberrypi/staggered_ctrl.cpp | 41 ++++++++---- > .../pipeline/raspberrypi/staggered_ctrl.h | 17 ++++- > test/ipa/ipa_wrappers_test.cpp | 2 + > 17 files changed, 199 insertions(+), 81 deletions(-) > > -- > 2.25.1 > >
Hi all, Another gentle nudge :) Thanks, Naush On Sat, 30 Jan 2021 at 09:17, Naushir Patuck <naush@raspberrypi.com> wrote: > Hi all, > > On Fri, 29 Jan 2021 at 11:16, Naushir Patuck <naush@raspberrypi.com> > wrote: > >> Hi, >> >> Here is the next revision of the patch series. The only difference >> between this >> and v3 is a change to the comment text as suggested by Laurent in patch >> 2/5. >> >> > With the recent merge of DelayedCtrls, patch 5/5 in this series is now > redundant. All other patches still remain unchanged and can be merged > without patch 5/5 for this work. > > As discussed with Niklas, I will work to port the changes from patch 5/5 > into DelayedCtrls at some point in the near future. > > Regards, > Naush > > >> Jacopo Mondi (1): >> libcamera: camera_sensor: Make VBLANK mandatory >> >> Naushir Patuck (4): >> libcamera: camera_sensor: Add frame length limits to CameraSensorInfo >> ipa: raspberrypi: Limit the calculated vblank based on the sensor mode >> ipa: raspberrypi: Pass the maximum allowable shutter speed into the >> AGC >> pipeline: raspberrypi: Add notion of priority write to StaggeredCtrl >> >> Documentation/sensor_driver_requirements.rst | 6 +- >> include/libcamera/internal/camera_sensor.h | 3 + >> src/ipa/raspberrypi/cam_helper.cpp | 16 ++--- >> src/ipa/raspberrypi/cam_helper.hpp | 5 +- >> src/ipa/raspberrypi/cam_helper_imx219.cpp | 6 +- >> src/ipa/raspberrypi/cam_helper_imx477.cpp | 4 +- >> src/ipa/raspberrypi/cam_helper_ov5647.cpp | 4 +- >> .../raspberrypi/controller/agc_algorithm.hpp | 1 + >> src/ipa/raspberrypi/controller/camera_mode.h | 2 + >> src/ipa/raspberrypi/controller/rpi/agc.cpp | 48 +++++++++----- >> src/ipa/raspberrypi/controller/rpi/agc.hpp | 3 + >> src/ipa/raspberrypi/raspberrypi.cpp | 66 ++++++++++++++----- >> src/libcamera/camera_sensor.cpp | 44 +++++++++++-- >> .../pipeline/raspberrypi/raspberrypi.cpp | 12 +++- >> .../pipeline/raspberrypi/staggered_ctrl.cpp | 41 ++++++++---- >> .../pipeline/raspberrypi/staggered_ctrl.h | 17 ++++- >> test/ipa/ipa_wrappers_test.cpp | 2 + >> 17 files changed, 199 insertions(+), 81 deletions(-) >> >> -- >> 2.25.1 >> >>
Hi, Here is the next revision of the patch series. The only difference between this and v3 is a change to the comment text as suggested by Laurent in patch 2/5. Thanks, Naush Jacopo Mondi (1): libcamera: camera_sensor: Make VBLANK mandatory Naushir Patuck (4): libcamera: camera_sensor: Add frame length limits to CameraSensorInfo ipa: raspberrypi: Limit the calculated vblank based on the sensor mode ipa: raspberrypi: Pass the maximum allowable shutter speed into the AGC pipeline: raspberrypi: Add notion of priority write to StaggeredCtrl Documentation/sensor_driver_requirements.rst | 6 +- include/libcamera/internal/camera_sensor.h | 3 + src/ipa/raspberrypi/cam_helper.cpp | 16 ++--- src/ipa/raspberrypi/cam_helper.hpp | 5 +- src/ipa/raspberrypi/cam_helper_imx219.cpp | 6 +- src/ipa/raspberrypi/cam_helper_imx477.cpp | 4 +- src/ipa/raspberrypi/cam_helper_ov5647.cpp | 4 +- .../raspberrypi/controller/agc_algorithm.hpp | 1 + src/ipa/raspberrypi/controller/camera_mode.h | 2 + src/ipa/raspberrypi/controller/rpi/agc.cpp | 48 +++++++++----- src/ipa/raspberrypi/controller/rpi/agc.hpp | 3 + src/ipa/raspberrypi/raspberrypi.cpp | 66 ++++++++++++++----- src/libcamera/camera_sensor.cpp | 44 +++++++++++-- .../pipeline/raspberrypi/raspberrypi.cpp | 12 +++- .../pipeline/raspberrypi/staggered_ctrl.cpp | 41 ++++++++---- .../pipeline/raspberrypi/staggered_ctrl.h | 17 ++++- test/ipa/ipa_wrappers_test.cpp | 2 + 17 files changed, 199 insertions(+), 81 deletions(-)