| Message ID | 20210106100659.8363-1-naush@raspberrypi.com |
|---|---|
| Headers | show |
| Series |
|
| Related | show |
Hi all, Gentle ping to see if this can be finalised. Many thanks, Naush On Wed, 6 Jan 2021 at 10:07, Naushir Patuck <naush@raspberrypi.com> wrote: > Hi all, > > Here is the next iteration of the FPS control patchset. This version has > all the various nits fixed: > > - Clip -> Clamp in a comment. > - Member definitions on separate lines to match the rest of the file. > - Ensure we handle the case where minFrameDuration > maxFrameDuration > without breaking. > - Expanded wording in the commit message for 3/3. > > The documentation for frameDurations control has been updated as well. > I've included a line about resetting to default values, together with a > todo to rationalise this as well as for other controls. Also simplified > the text surrounding metadata return values. > > Many thanks, > Naush > > Naushir Patuck (3): > libcamera: controls: Add frame duration control > libcamera: raspberrypi: Add control of sensor vblanking > ipa: raspberrypi: config: Update shutter speeds for imx219/477 and > ov5647 > > include/libcamera/ipa/raspberrypi.h | 1 + > src/ipa/raspberrypi/cam_helper.cpp | 35 +++++++++++- > src/ipa/raspberrypi/cam_helper.hpp | 15 ++++- > src/ipa/raspberrypi/cam_helper_imx219.cpp | 13 ++++- > src/ipa/raspberrypi/cam_helper_imx477.cpp | 11 +++- > src/ipa/raspberrypi/cam_helper_ov5647.cpp | 11 +++- > src/ipa/raspberrypi/data/imx219.json | 15 ++++- > src/ipa/raspberrypi/data/imx477.json | 15 ++++- > src/ipa/raspberrypi/data/ov5647.json | 15 ++++- > src/ipa/raspberrypi/raspberrypi.cpp | 56 ++++++++++++++++--- > src/libcamera/control_ids.yaml | 38 +++++++++++++ > .../pipeline/raspberrypi/raspberrypi.cpp | 3 +- > 12 files changed, 207 insertions(+), 21 deletions(-) > > -- > 2.25.1 > >
Hi Naush, On Mon, Jan 11, 2021 at 01:43:24PM +0000, Naushir Patuck wrote: > Hi all, > > Gentle ping to see if this can be finalised. I've finished reviewing the series. There's just one sentence in the documentation that I'm not sure to understand. If we can clarify this by e-mail there's no need to post a v12, I can apply the correction to the patch when pushing. > On Wed, 6 Jan 2021 at 10:07, Naushir Patuck <naush@raspberrypi.com> wrote: > > > Hi all, > > > > Here is the next iteration of the FPS control patchset. This version has > > all the various nits fixed: > > > > - Clip -> Clamp in a comment. > > - Member definitions on separate lines to match the rest of the file. > > - Ensure we handle the case where minFrameDuration > maxFrameDuration > > without breaking. > > - Expanded wording in the commit message for 3/3. > > > > The documentation for frameDurations control has been updated as well. > > I've included a line about resetting to default values, together with a > > todo to rationalise this as well as for other controls. Also simplified > > the text surrounding metadata return values. > > > > Many thanks, > > Naush > > > > Naushir Patuck (3): > > libcamera: controls: Add frame duration control > > libcamera: raspberrypi: Add control of sensor vblanking > > ipa: raspberrypi: config: Update shutter speeds for imx219/477 and > > ov5647 > > > > include/libcamera/ipa/raspberrypi.h | 1 + > > src/ipa/raspberrypi/cam_helper.cpp | 35 +++++++++++- > > src/ipa/raspberrypi/cam_helper.hpp | 15 ++++- > > src/ipa/raspberrypi/cam_helper_imx219.cpp | 13 ++++- > > src/ipa/raspberrypi/cam_helper_imx477.cpp | 11 +++- > > src/ipa/raspberrypi/cam_helper_ov5647.cpp | 11 +++- > > src/ipa/raspberrypi/data/imx219.json | 15 ++++- > > src/ipa/raspberrypi/data/imx477.json | 15 ++++- > > src/ipa/raspberrypi/data/ov5647.json | 15 ++++- > > src/ipa/raspberrypi/raspberrypi.cpp | 56 ++++++++++++++++--- > > src/libcamera/control_ids.yaml | 38 +++++++++++++ > > .../pipeline/raspberrypi/raspberrypi.cpp | 3 +- > > 12 files changed, 207 insertions(+), 21 deletions(-)
Hi all, Here is the next iteration of the FPS control patchset. This version has all the various nits fixed: - Clip -> Clamp in a comment. - Member definitions on separate lines to match the rest of the file. - Ensure we handle the case where minFrameDuration > maxFrameDuration without breaking. - Expanded wording in the commit message for 3/3. The documentation for frameDurations control has been updated as well. I've included a line about resetting to default values, together with a todo to rationalise this as well as for other controls. Also simplified the text surrounding metadata return values. Many thanks, Naush Naushir Patuck (3): libcamera: controls: Add frame duration control libcamera: raspberrypi: Add control of sensor vblanking ipa: raspberrypi: config: Update shutter speeds for imx219/477 and ov5647 include/libcamera/ipa/raspberrypi.h | 1 + src/ipa/raspberrypi/cam_helper.cpp | 35 +++++++++++- src/ipa/raspberrypi/cam_helper.hpp | 15 ++++- src/ipa/raspberrypi/cam_helper_imx219.cpp | 13 ++++- src/ipa/raspberrypi/cam_helper_imx477.cpp | 11 +++- src/ipa/raspberrypi/cam_helper_ov5647.cpp | 11 +++- src/ipa/raspberrypi/data/imx219.json | 15 ++++- src/ipa/raspberrypi/data/imx477.json | 15 ++++- src/ipa/raspberrypi/data/ov5647.json | 15 ++++- src/ipa/raspberrypi/raspberrypi.cpp | 56 ++++++++++++++++--- src/libcamera/control_ids.yaml | 38 +++++++++++++ .../pipeline/raspberrypi/raspberrypi.cpp | 3 +- 12 files changed, 207 insertions(+), 21 deletions(-)