[libcamera-devel,v10,0/3] raspberrypi: FPS control
mbox series

Message ID 20201218100626.205134-1-naush@raspberrypi.com
Headers show
Series
  • raspberrypi: FPS control
Related show

Message

Naushir Patuck Dec. 18, 2020, 10:06 a.m. UTC 
Hi all,

Here is the next iteration of the FPS control patch set.

Jacopo, based on our discussion yesterday, I've modified the wording in the control documentation.  Only the return metadata part of the text has changed, but I've removed your review tag from patch 1/3 so that you have a chance to go through the new text again.

After having thought about it a bit more, setting the correct values of frame durations (based on the new text description) in the Raspberry Pi IPA is not currently possible without my next series of changes to get the AGC to handle frame durations correctly.  So I have put a \todo in the code to fix this correctly in the follow up series.  At present, the code simply returns the values that were provided by the user.  Hope that is ok.

Other than that, the minor typos in patch 2/3 have also been fixed.

Thanks,
Naush

Naushir Patuck (3):
  libcamera: controls: Add frame duration control
  libcamera: raspberrypi: Add control of sensor vblanking
  ipa: raspberrypi: config: Update shutter speeds for imx219/477 and
    ov5647

 include/libcamera/ipa/raspberrypi.h           |  1 +
 src/ipa/raspberrypi/cam_helper.cpp            | 35 ++++++++++++-
 src/ipa/raspberrypi/cam_helper.hpp            | 15 +++++-
 src/ipa/raspberrypi/cam_helper_imx219.cpp     | 13 ++++-
 src/ipa/raspberrypi/cam_helper_imx477.cpp     | 11 +++-
 src/ipa/raspberrypi/cam_helper_ov5647.cpp     | 11 +++-
 src/ipa/raspberrypi/data/imx219.json          | 15 +++++-
 src/ipa/raspberrypi/data/imx477.json          | 15 +++++-
 src/ipa/raspberrypi/data/ov5647.json          | 15 +++++-
 src/ipa/raspberrypi/raspberrypi.cpp           | 52 ++++++++++++++++---
 src/libcamera/control_ids.yaml                | 41 +++++++++++++++
 .../pipeline/raspberrypi/raspberrypi.cpp      |  3 +-
 12 files changed, 207 insertions(+), 20 deletions(-)