| Message ID | 20201126123203.19105-1-david.plowman@raspberrypi.com |
|---|---|
| Headers | show
Return-Path: <libcamera-devel-bounces@lists.libcamera.org> X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D7F9CBE176 for <parsemail@patchwork.libcamera.org>; Thu, 26 Nov 2020 12:32:11 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5B32463458; Thu, 26 Nov 2020 13:32:11 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="H/ZVG6Oj"; dkim-atps=neutral Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D48463408 for <libcamera-devel@lists.libcamera.org>; Thu, 26 Nov 2020 13:32:10 +0100 (CET) Received: by mail-ej1-x635.google.com with SMTP id bo9so2622735ejb.13 for <libcamera-devel@lists.libcamera.org>; Thu, 26 Nov 2020 04:32:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=K9F4kZm0BYI5FUUYu1qyevSvG07MqDw41hWu7qjkLZo=; b=H/ZVG6Ojfn7J/Sp4YqiW4hmYt4BaTsuvyXmkoUDyfXtb9tk67TSf3WZTvJdBljWCDO 5CkSuasFeG2xVkYqbBzbuEbzDEK+eCkSlEszfjku6wUdSMJ6pa9Y64wwbBdBu/XOy/vt lqh1/CJEDWftMSgLYfEtx9TtxeUWi2XfCUDppp8H51JfG0SbFzuxDksyPZJD1JG2T2Yp xdRs3h9OgvnOB0gTnuyFPrWJ8j+QxgkZvG4V9KL5zoA/zN3pKI2zJoLZow6RQ652E2E2 /oIYwwpz85EJPebURNpNr4pqDYgoLWloztKBPm06/AOpS4uA/r1HAxOt2B7QQE6doX5f GliA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=K9F4kZm0BYI5FUUYu1qyevSvG07MqDw41hWu7qjkLZo=; b=QEXGxlAzcFGxEp4h2t0+YSTX7dfMh5bb7IPWg1SuLow1eaSIvd5N/WuFv2nQ64vfkV pofJJXMZG8vqiwBQUGs+bK9+VHB5DrChOMSCGj1kLSze0vdDcTguxYGIgYwxEaC7KUyY Vk7kiXPUb3S1vR5UknRQmZXt6oxTcpb/5Mk6eAX1aqgSG4W9RJm2BpaROjPof3s5xa7c Rf7FKt+CAU48gUNTQGpPS5vip1bIztoSsNmad0DWXsmpcLJqWAHWPhF3BGYHAunR/YjU +hSVxuZJku2dlmiIYzTYiqoQgTL5s/yuX5A6+1BMeeHnMK7Hx3eiXorfz/bC4Z24nfK1 NQPA== X-Gm-Message-State: AOAM530LAOAiis3JtPgtkCOY5LPym2zq3WgQFBuO29p8WOSwKBVrF7Do 6ApGyjdFkTv4flfGCtHWcdYM2vP9ky7QiWx7 X-Google-Smtp-Source: ABdhPJzqRwADZBEaXTSW72rzkuzPbn8ifgp2rVtIVNroaktFdl7mGH8ypDHHVmxRlyyL4U7N8Lybmg== X-Received: by 2002:a17:906:38cc:: with SMTP id r12mr2441625ejd.277.1606393929248; Thu, 26 Nov 2020 04:32:09 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id u5sm3064354edp.5.2020.11.26.04.32.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 04:32:08 -0800 (PST) From: David Plowman <david.plowman@raspberrypi.com> To: libcamera-devel@lists.libcamera.org Date: Thu, 26 Nov 2020 12:31:59 +0000 Message-Id: <20201126123203.19105-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/4] Raspberry Pi AGC improvements X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <libcamera-devel.lists.libcamera.org> List-Unsubscribe: <https://lists.libcamera.org/options/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe> List-Archive: <https://lists.libcamera.org/pipermail/libcamera-devel/> List-Post: <mailto:libcamera-devel@lists.libcamera.org> List-Help: <mailto:libcamera-devel-request@lists.libcamera.org?subject=help> List-Subscribe: <https://lists.libcamera.org/listinfo/libcamera-devel>, <mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" <libcamera-devel-bounces@lists.libcamera.org> |
| Series |
|
| Related |
show
|
Hi Thanks for the comments. This revised set turns the middle patch into two, implementing Naush's suggestion. The first of these gives AGC a custom implementation of pause/resume, making the subsequent patch simpler. Functionally nothing is changed, and the other patches unrelated to this are untouched. Best regards David David Plowman (4): src: ipa: raspberrypi: Avoid AGC filtering when both gain and shutter specified src: ipa: raspberrypi: agc: Make AGC handle Pause/Resume for itself src: ipa: raspberrypi: Improve behaviour when AE disabled src: ipa: raspberrypi: Fix initial AGC oscillation for imx219 sensor src/ipa/raspberrypi/controller/rpi/agc.cpp | 31 +++++++++++++++++++++- src/ipa/raspberrypi/controller/rpi/agc.hpp | 5 ++++ src/ipa/raspberrypi/data/imx219.json | 4 +-- src/ipa/raspberrypi/raspberrypi.cpp | 9 +------ 4 files changed, 38 insertions(+), 11 deletions(-)