[libcamera-devel,0/2] media-libs/libcamera: Small fixes for IPA builds
mbox series

Message ID 20201109011656.2560957-1-niklas.soderlund@ragnatech.se
Headers show
Series
  • media-libs/libcamera: Small fixes for IPA builds
Related show

Message

Niklas Söderlund Nov. 9, 2020, 1:16 a.m. UTC 
Hi Tomasz,

This small series fix two issues I have when building libcamera for 
CrOS. I'm unsure how to best submit them "correctly" for upstream so I 
send them to you. If you wish me to resubmit thru some other channel 
just let me know.

Patch 1/2 I have had in my tree for quiet some time and deals with that 
the android option was turned into a meson feature instead of a boolean.  
Patch 2/2 is a recent find that deals with how libcamera signs its IPA 
modules and how CrOS build system strips binaries.

Niklas Söderlund (2):
  media-libs/libcamera: Android support is a feature not a boolean
  media-libs/libcamera: Do not strip IPA binaries

 media-libs/libcamera/libcamera-9999.ebuild | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Tomasz Figa Nov. 10, 2020, 10:11 a.m. UTC | #1 
Hi Niklas,

On Mon, Nov 9, 2020 at 10:17 AM Niklas Söderlund
<niklas.soderlund@ragnatech.se> wrote:
>
> Hi Tomasz,
>
> This small series fix two issues I have when building libcamera for
> CrOS. I'm unsure how to best submit them "correctly" for upstream so I
> send them to you. If you wish me to resubmit thru some other channel
> just let me know.
>
> Patch 1/2 I have had in my tree for quiet some time and deals with that
> the android option was turned into a meson feature instead of a boolean.
> Patch 2/2 is a recent find that deals with how libcamera signs its IPA
> modules and how CrOS build system strips binaries.
>
> Niklas Söderlund (2):
>   media-libs/libcamera: Android support is a feature not a boolean
>   media-libs/libcamera: Do not strip IPA binaries
>
>  media-libs/libcamera/libcamera-9999.ebuild | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Thanks for the patches. I replied to each of them individually.

In general, changes to Chromium OS are submitted via Gerrit code review:
https://chromium.googlesource.com/chromiumos/docs/+/master/contributing.md

Please follow that workflow in the future.

Best regards,
Tomasz