[libcamera-devel,0/3] android: jpeg: exif: Embed a JPEG-encoded thumbnail
mbox series

Message ID 20201026140134.44166-1-email@uajain.com
Headers show
Series
  • android: jpeg: exif: Embed a JPEG-encoded thumbnail
Related show

Message

Umang Jain Oct. 26, 2020, 2:01 p.m. UTC 
After refactoring the jpeg encoder bits and introducing a new
PostProcessor interface, it's time to introduce a simple image
thumbnailer to thumbnail the frames captured and embed it via libexif.

The patches have been tested locally via vivid PH/cam-file-sink, so
there is some level of confidence in the patches. If anyone is interested,
I can provide a wip: branch which I used. There were some tweaks to use
the PostProcessor (instead of the encoder directly) but nothing major.

Patch 1/3 is simply a bugfix I encountered when testing the patches.
Patch 2/3 has been reviewed and approved before, when the PostProcessor
and Encoder had some new function signatures changes recently hence,
I thought that it's best to drop the review tags and ask for a re-review.
Patch 3/3 is the actual meat of this series, which in my opinion has been
quite simplified after a lot of churn (finally!).

Thanks!

Umang Jain (3):
  android: jpeg: Return encoded bytes size from PostProcessorJpeg
  android: jpeg: encoder_libjpeg: Allow encoding raw frame bytes
  android: jpeg: exif: Embed a JPEG-encoded thumbnail

 src/android/jpeg/encoder_libjpeg.cpp     |  18 ++--
 src/android/jpeg/encoder_libjpeg.h       |   7 +-
 src/android/jpeg/exif.cpp                |  16 +++-
 src/android/jpeg/exif.h                  |   1 +
 src/android/jpeg/post_processor_jpeg.cpp |  37 +++++++-
 src/android/jpeg/post_processor_jpeg.h   |   8 +-
 src/android/jpeg/thumbnailer.cpp         | 109 +++++++++++++++++++++++
 src/android/jpeg/thumbnailer.h           |  37 ++++++++
 src/android/meson.build                  |   1 +
 9 files changed, 222 insertions(+), 12 deletions(-)
 create mode 100644 src/android/jpeg/thumbnailer.cpp
 create mode 100644 src/android/jpeg/thumbnailer.h