[libcamera-devel,v7,0/8] libcamera: Framework changes to prepare for multiple streams support
mbox series

Message ID 20190417135858.23914-1-jacopo@jmondi.org
Headers show
Series
  • libcamera: Framework changes to prepare for multiple streams support
Related show

Message

Jacopo Mondi April 17, 2019, 1:58 p.m. UTC 
Hello, we're getting close, hopefully.

I have included the received comments, mostly on documentation.
Notable changes:

3/7: do not squash with 2/7 and update the IPU3 allocateBuffers() implementation
to clean up after itself.
4/7: new patch
7/7: drop the IPU3 example (and include review comments)

Thanks
  j

Jacopo Mondi (8):
  libcamera: stream: Make Stream inheritable
  libcamera: camera: Pass the stream set to allocate/freeBuffers()
  libcamera: camera: Don't call freeBuffer() on allocateBuffer() error
  libcamera: v4l2_device: Propagate releaseBuffers() error
  libcamera: request: Add hasPendingBuffers() method
  libcamera: camera: Validate Request before queueing it
  libcamera: request: Expose the Stream to Buffers map
  libcamera: buffer: Store Request reference in Buffer

 include/libcamera/buffer.h               |  6 ++++
 include/libcamera/request.h              |  3 ++
 include/libcamera/stream.h               |  4 +--
 src/libcamera/buffer.cpp                 | 25 +++++++++++++++-
 src/libcamera/camera.cpp                 | 25 ++++++++--------
 src/libcamera/include/pipeline_handler.h |  6 ++--
 src/libcamera/pipeline/ipu3/ipu3.cpp     | 32 ++++++++++++++------
 src/libcamera/pipeline/uvcvideo.cpp      | 13 ++++++---
 src/libcamera/pipeline/vimc.cpp          | 13 ++++++---
 src/libcamera/pipeline_handler.cpp       | 11 +++----
 src/libcamera/request.cpp                | 37 ++++++++++++++++++++++--
 src/libcamera/v4l2_device.cpp            |  3 +-
 12 files changed, 134 insertions(+), 44 deletions(-)

--
2.21.0

Comments

Jacopo Mondi April 18, 2019, 1:39 p.m. UTC | #1 
Hello,

On Wed, Apr 17, 2019 at 03:58:50PM +0200, Jacopo Mondi wrote:
> Hello, we're getting close, hopefully.
>
> I have included the received comments, mostly on documentation.
> Notable changes:
>
> 3/7: do not squash with 2/7 and update the IPU3 allocateBuffers() implementation
> to clean up after itself.
> 4/7: new patch
> 7/7: drop the IPU3 example (and include review comments)
>

I have included comments received on this series and I have now pused
to master.

Thanks for review and suggestions