[libcamera-devel,v4,00/15] Shadowed Variables
mbox series

Message ID 20201021154148.511505-1-kieran.bingham@ideasonboard.com
Headers show
Series
  • Shadowed Variables
Related show

Message

Kieran Bingham Oct. 21, 2020, 3:41 p.m. UTC 
Final spin of the shadowed variables series. (hopefully)

So a few more additions crept in to this series to cover the
V4L2 layer, and updates that have been made in the android layer.

Hopefully this is 'done' ;-)


Kieran Bingham (15):
  libcamera: thread: Prevent shadowing of signal name
  libcamera: pipeline: Prevent variable shadowing
  libcamera: pipeline: Use existing variable definitions
  libcamera: pipeline: rpi_stream: Explicitly name requestBuffer
  libcamera: v4l2_videodevice: Prevent shadowing of V4L2BufferCache
    members
  ipa: raspberrypi: Re-use iterator variable
  android: camera_device: Use existing variable definitions
  android: camera_device: use member style on Camera3RequestDescriptor
  android: camera_device: Rename shadowed variable
  android: metadata: Disable -Wshadow
  v4l2: camera: Prevent shadowing within V4L2Camera::Buffer
  cam: options: Rename optional arg to prevent shadowing
  qcam: main_window: Explicitly name raw buffer
  test: v4l2_videodevice: Prevent variable shadowing of format
  meson: Enable shadowed variable warning

 include/libcamera/internal/v4l2_videodevice.h |  4 +-
 meson.build                                   |  1 +
 src/android/camera_device.cpp                 | 64 +++++++++----------
 src/android/camera_device.h                   | 10 +--
 src/android/meson.build                       |  1 +
 src/cam/options.cpp                           | 10 +--
 src/ipa/raspberrypi/controller/rpi/alsc.cpp   |  6 +-
 .../pipeline/raspberrypi/raspberrypi.cpp      |  8 +--
 .../pipeline/raspberrypi/rpi_stream.cpp       |  8 +--
 src/libcamera/pipeline/simple/converter.cpp   |  8 +--
 src/libcamera/pipeline/simple/simple.cpp      |  8 +--
 src/libcamera/pipeline/uvcvideo/uvcvideo.cpp  |  4 +-
 src/libcamera/thread.cpp                      |  8 +--
 src/libcamera/v4l2_videodevice.cpp            | 12 ++--
 src/qcam/main_window.cpp                      |  8 +--
 src/v4l2/v4l2_camera.h                        |  6 +-
 src/v4l2/v4l2_camera_proxy.cpp                |  4 +-
 test/v4l2_videodevice/formats.cpp             |  6 +-
 18 files changed, 89 insertions(+), 87 deletions(-)