[libcamera-devel,v3,00/11] Shadowed Variables
mbox series

Message ID 20201016090014.64703-1-kieran.bingham@ideasonboard.com
Headers show
Series
  • Shadowed Variables
Related show

Message

Kieran Bingham Oct. 16, 2020, 9 a.m. UTC 
Final spin of the shadowed variables series.

Minor fixups mostly to renaming the use of the word 'alias' in this
series to be 'shadow'.

All tests pass, and I'll push this this evening or next week if no
blockers are identified.

Kieran Bingham (11):
  cam: options: Rename optional arg to prevent shadowing
  qcam: main_window: Explicitly name raw buffer
  libcamera: thread: Prevent shadowing of signal name
  libcamera: pipeline: Prevent variable shadowing
  libcamera: pipeline: Use existing variable definitions
  libcamera: pipeline: rpi_stream: Explicitly name requestBuffer
  libcamera: v4l2_videodevice: Prevent shadowing of V4L2BufferCache
    members
  test: v4l2_videodevice: Prevent variable shadowing of format
  ipa: raspberrypi: Re-use iterator variable
  android: metadata: Disable -Wshadow
  meson: Enable shadowed variable warning

 include/libcamera/internal/v4l2_videodevice.h      |  4 ++--
 meson.build                                        |  1 +
 src/android/meson.build                            |  1 +
 src/cam/options.cpp                                | 10 +++++-----
 src/ipa/raspberrypi/controller/rpi/alsc.cpp        |  6 +++---
 src/libcamera/pipeline/raspberrypi/raspberrypi.cpp |  8 ++++----
 src/libcamera/pipeline/raspberrypi/rpi_stream.cpp  |  8 ++++----
 src/libcamera/pipeline/simple/converter.cpp        |  8 ++++----
 src/libcamera/pipeline/simple/simple.cpp           |  8 ++++----
 src/libcamera/pipeline/uvcvideo/uvcvideo.cpp       |  4 ++--
 src/libcamera/thread.cpp                           |  8 ++++----
 src/libcamera/v4l2_videodevice.cpp                 | 12 ++++++------
 src/qcam/main_window.cpp                           |  8 ++++----
 test/v4l2_videodevice/formats.cpp                  |  6 +++---
 14 files changed, 47 insertions(+), 45 deletions(-)