[libcamera-devel,v2,00/11] Shadowed Variables
mbox series

Message ID 20201015223750.58563-1-kieran.bingham@ideasonboard.com
Headers show
Series
  • Shadowed Variables
Related show

Message

Kieran Bingham Oct. 15, 2020, 10:37 p.m. UTC 
During development, I hit an awkward issue with a variable being aliased
in the constructor, which caused horrendous pain debugging.

We can warn on shadowed variables to prevent this occuring and this
series introduces that.


Kieran Bingham (11):
  cam: options: Rename optional arg to prevent aliasing
  qcam: main_window: Explicitly name raw buffer
  libcamera: thread: Prevent aliasing of signal name
  libcamera: pipeline: Prevent variable aliasing
  libcamera: pipeline: Use existing variable definitions
  libcamera: pipeline: rpi_stream: Explicitly name requestBuffer
  libcamera: v4l2_videodevice: Prevent aliasing of V4L2BufferCache
    members
  test: v4l2_videodevice: Prevent variable aliasing of format
  ipa: raspberrypi: Re-use iterator variable
  android: metadata: Disable -Wshadow
  meson: Enable shadowed variable warning

 include/libcamera/internal/v4l2_videodevice.h      |  4 ++--
 meson.build                                        |  1 +
 src/android/meson.build                            |  1 +
 src/cam/options.cpp                                | 10 +++++-----
 src/ipa/raspberrypi/controller/rpi/alsc.cpp        |  6 +++---
 src/libcamera/pipeline/raspberrypi/raspberrypi.cpp |  8 ++++----
 src/libcamera/pipeline/raspberrypi/rpi_stream.cpp  |  8 ++++----
 src/libcamera/pipeline/simple/converter.cpp        |  8 ++++----
 src/libcamera/pipeline/simple/simple.cpp           |  8 ++++----
 src/libcamera/pipeline/uvcvideo/uvcvideo.cpp       |  4 ++--
 src/libcamera/thread.cpp                           |  8 ++++----
 src/libcamera/v4l2_videodevice.cpp                 | 12 ++++++------
 src/qcam/main_window.cpp                           |  8 ++++----
 test/v4l2_videodevice/formats.cpp                  |  6 +++---
 14 files changed, 47 insertions(+), 45 deletions(-)