[libcamera-devel,2/4] libcamera: device_enumerator: Break line longer than 80 columns

Message ID 20190212222021.28517-3-jacopo@jmondi.org
State Accepted
Headers show
Series
  • libcamera: mixed updated
Related show

Commit Message

Jacopo Mondi Feb. 12, 2019, 10:20 p.m. UTC
Since there is no valid reason to exceed 80 columns for this lane, break
it.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 src/libcamera/device_enumerator.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Laurent Pinchart Feb. 12, 2019, 10:38 p.m. UTC | #1
Hi Jacopo,

Thank you for the patch.

On Tue, Feb 12, 2019 at 11:20:19PM +0100, Jacopo Mondi wrote:
> Since there is no valid reason to exceed 80 columns for this lane, break
> it.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/device_enumerator.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp
> index 703b03dd418a..03923b3bb457 100644
> --- a/src/libcamera/device_enumerator.cpp
> +++ b/src/libcamera/device_enumerator.cpp
> @@ -234,7 +234,8 @@ int DeviceEnumerator::addDevice(const std::string &deviceNode)
>  		if (entity->deviceMajor() == 0 && entity->deviceMinor() == 0)
>  			continue;
>  
> -		std::string deviceNode = lookupDeviceNode(entity->deviceMajor(), entity->deviceMinor());
> +		std::string deviceNode = lookupDeviceNode(entity->deviceMajor(),
> +							  entity->deviceMinor());
>  		if (deviceNode.empty())
>  			return -EINVAL;
>
Niklas Söderlund Feb. 13, 2019, 10:59 a.m. UTC | #2
Hi Jacopo,

Thanks for your patch,

On 2019-02-12 23:20:19 +0100, Jacopo Mondi wrote:
> Since there is no valid reason to exceed 80 columns for this lane, break
> it.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  src/libcamera/device_enumerator.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp
> index 703b03dd418a..03923b3bb457 100644
> --- a/src/libcamera/device_enumerator.cpp
> +++ b/src/libcamera/device_enumerator.cpp
> @@ -234,7 +234,8 @@ int DeviceEnumerator::addDevice(const std::string &deviceNode)
>  		if (entity->deviceMajor() == 0 && entity->deviceMinor() == 0)
>  			continue;
>  
> -		std::string deviceNode = lookupDeviceNode(entity->deviceMajor(), entity->deviceMinor());
> +		std::string deviceNode = lookupDeviceNode(entity->deviceMajor(),
> +							  entity->deviceMinor());
>  		if (deviceNode.empty())
>  			return -EINVAL;
>  
> -- 
> 2.20.1
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp
index 703b03dd418a..03923b3bb457 100644
--- a/src/libcamera/device_enumerator.cpp
+++ b/src/libcamera/device_enumerator.cpp
@@ -234,7 +234,8 @@  int DeviceEnumerator::addDevice(const std::string &deviceNode)
 		if (entity->deviceMajor() == 0 && entity->deviceMinor() == 0)
 			continue;
 
-		std::string deviceNode = lookupDeviceNode(entity->deviceMajor(), entity->deviceMinor());
+		std::string deviceNode = lookupDeviceNode(entity->deviceMajor(),
+							  entity->deviceMinor());
 		if (deviceNode.empty())
 			return -EINVAL;