[libcamera-devel,0/2] libcamera: ipu3: more review fixes
mbox series

Message ID 20190126162859.32031-1-jacopo@jmondi.org
Headers show
Series
  • libcamera: ipu3: more review fixes
Related show

Message

Jacopo Mondi Jan. 26, 2019, 4:28 p.m. UTC 
Address review comments on the IPU3 pipeline handler CameraData usage.

Thanks
  j

Jacopo Mondi (2):
  libcamera: ipu3: Add method to retrieve camera data
  libcamera: ipu3: Re-work camera data registration

 src/libcamera/pipeline/ipu3/ipu3.cpp | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

--
2.20.1

Comments

Laurent Pinchart Jan. 26, 2019, 4:41 p.m. UTC | #1 
Hi Jacopo,

Thanks you for the patches.

On Sat, Jan 26, 2019 at 05:28:57PM +0100, Jacopo Mondi wrote:
> Address review comments on the IPU3 pipeline handler CameraData usage.

You may want to expland the commit message of 2/2 to explain why the
reworked version is an improvement. In any way,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Jacopo Mondi (2):
>   libcamera: ipu3: Add method to retrieve camera data
>   libcamera: ipu3: Re-work camera data registration
> 
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
>
Jacopo Mondi Jan. 29, 2019, 2:55 p.m. UTC | #2 
Hi Laurent,

On Sat, Jan 26, 2019 at 06:41:11PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thanks you for the patches.
>
> On Sat, Jan 26, 2019 at 05:28:57PM +0100, Jacopo Mondi wrote:
> > Address review comments on the IPU3 pipeline handler CameraData usage.
>
> You may want to expland the commit message of 2/2 to explain why the
> reworked version is an improvement. In any way,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks, comment expanded and pushed

Thanks
  j

>
> > Jacopo Mondi (2):
> >   libcamera: ipu3: Add method to retrieve camera data
> >   libcamera: ipu3: Re-work camera data registration
> >
> >  src/libcamera/pipeline/ipu3/ipu3.cpp | 16 ++++++++++------
> >  1 file changed, 10 insertions(+), 6 deletions(-)
> >
>
> --
> Regards,
>
> Laurent Pinchart