[libcamera-devel] libcamera: pipeline: sort forward declarations of classes

Message ID 20190127005534.21744-1-niklas.soderlund@ragnatech.se
State Accepted
Commit 825bee2d112217c39f1bf4782a1f5fe359a83a28
Headers show
Series
  • [libcamera-devel] libcamera: pipeline: sort forward declarations of classes
Related show

Commit Message

Niklas Söderlund Jan. 27, 2019, 12:55 a.m. UTC
Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 src/libcamera/include/pipeline_handler.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jacopo Mondi Jan. 27, 2019, 10:21 a.m. UTC | #1
Hi Niklas,

On Sun, Jan 27, 2019 at 01:55:34AM +0100, Niklas Söderlund wrote:
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

My bad, thanks for fixing.

Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks
  j

> ---
>  src/libcamera/include/pipeline_handler.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h
> index ca77a40b96e69b66..080997e22e545e01 100644
> --- a/src/libcamera/include/pipeline_handler.h
> +++ b/src/libcamera/include/pipeline_handler.h
> @@ -14,11 +14,11 @@
>
>  namespace libcamera {
>
> +class Camera;
>  class CameraManager;
>  class DeviceEnumerator;
>  class MediaDevice;
>
> -class Camera;
>  class CameraData
>  {
>  public:
> --
> 2.20.1
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
Niklas Söderlund Jan. 27, 2019, 1:05 p.m. UTC | #2
Hi Jacopo,

On 2019-01-27 11:21:22 +0100, Jacopo Mondi wrote:
> Hi Niklas,
> 
> On Sun, Jan 27, 2019 at 01:55:34AM +0100, Niklas Söderlund wrote:
> > Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> 
> My bad, thanks for fixing.
> 
> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>

Thanks, pushed.

> 
> Thanks
>   j
> 
> > ---
> >  src/libcamera/include/pipeline_handler.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h
> > index ca77a40b96e69b66..080997e22e545e01 100644
> > --- a/src/libcamera/include/pipeline_handler.h
> > +++ b/src/libcamera/include/pipeline_handler.h
> > @@ -14,11 +14,11 @@
> >
> >  namespace libcamera {
> >
> > +class Camera;
> >  class CameraManager;
> >  class DeviceEnumerator;
> >  class MediaDevice;
> >
> > -class Camera;
> >  class CameraData
> >  {
> >  public:
> > --
> > 2.20.1
> >
> > _______________________________________________
> > libcamera-devel mailing list
> > libcamera-devel@lists.libcamera.org
> > https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/src/libcamera/include/pipeline_handler.h b/src/libcamera/include/pipeline_handler.h
index ca77a40b96e69b66..080997e22e545e01 100644
--- a/src/libcamera/include/pipeline_handler.h
+++ b/src/libcamera/include/pipeline_handler.h
@@ -14,11 +14,11 @@ 
 
 namespace libcamera {
 
+class Camera;
 class CameraManager;
 class DeviceEnumerator;
 class MediaDevice;
 
-class Camera;
 class CameraData
 {
 public: