[libcamera-devel] libcamera: log: Fix two typos.

Message ID 20190123142445.29416-1-kieran.bingham@ideasonboard.com
State Accepted
Headers show
Series
  • [libcamera-devel] libcamera: log: Fix two typos.
Related show

Commit Message

Kieran Bingham Jan. 23, 2019, 2:24 p.m. UTC
Two incorrect spellings are fixed.
 'logr' -> 'log'
 'environement' -> 'environment'

Fixes: 747ace042cc1 ("libcamera: log: Get log levels from the environment")
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 src/libcamera/log.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Niklas Söderlund Jan. 23, 2019, 2:40 p.m. UTC | #1
Hi Kieran,

Thanks for your work.

On 2019-01-23 14:24:45 +0000, Kieran Bingham wrote:
> Two incorrect spellings are fixed.
>  'logr' -> 'log'
>  'environement' -> 'environment'
> 
> Fixes: 747ace042cc1 ("libcamera: log: Get log levels from the environment")
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  src/libcamera/log.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp
> index 241dc5395976..dc88414c338a 100644
> --- a/src/libcamera/log.cpp
> +++ b/src/libcamera/log.cpp
> @@ -134,7 +134,7 @@ void Logger::parseLogFile()
>  /**
>   * \brief Parse the log levels from the environment
>   *
> - * The logr levels are stored in LIBCAMERA_LOG_LEVELS environement variable as a list
> + * The log levels are stored in LIBCAMERA_LOG_LEVELS environment variable as a list
>   * of "category=level" pairs, separated by commas (','). Parse the variable and
>   * store the levels to configure all log categories.
>   */
> -- 
> 2.19.1
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
Laurent Pinchart Jan. 23, 2019, 3:40 p.m. UTC | #2
Hi Kieran,

Thank you for the patch..

On Wed, Jan 23, 2019 at 02:24:45PM +0000, Kieran Bingham wrote:
> Two incorrect spellings are fixed.
>  'logr' -> 'log'
>  'environement' -> 'environment'
> 
> Fixes: 747ace042cc1 ("libcamera: log: Get log levels from the environment")
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
>  src/libcamera/log.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp
> index 241dc5395976..dc88414c338a 100644
> --- a/src/libcamera/log.cpp
> +++ b/src/libcamera/log.cpp
> @@ -134,7 +134,7 @@ void Logger::parseLogFile()
>  /**
>   * \brief Parse the log levels from the environment
>   *
> - * The logr levels are stored in LIBCAMERA_LOG_LEVELS environement variable as a list
> + * The log levels are stored in LIBCAMERA_LOG_LEVELS environment variable as a list

While at it, s/in /in the /.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I'll push it.

>   * of "category=level" pairs, separated by commas (','). Parse the variable and
>   * store the levels to configure all log categories.
>   */

Patch

diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp
index 241dc5395976..dc88414c338a 100644
--- a/src/libcamera/log.cpp
+++ b/src/libcamera/log.cpp
@@ -134,7 +134,7 @@  void Logger::parseLogFile()
 /**
  * \brief Parse the log levels from the environment
  *
- * The logr levels are stored in LIBCAMERA_LOG_LEVELS environement variable as a list
+ * The log levels are stored in LIBCAMERA_LOG_LEVELS environment variable as a list
  * of "category=level" pairs, separated by commas (','). Parse the variable and
  * store the levels to configure all log categories.
  */