[libcamera-devel,0/6] Random documentation fixes
mbox series

Message ID 20200604134300.2986113-1-marvin.schmidt1987@gmail.com
Headers show
Series
  • Random documentation fixes
Related show

Message

Marvin Schmidt June 4, 2020, 1:42 p.m. UTC 
Just a couple of fixes for minor documentation problems I stumpled upon while
getting familiar with tne codebase.

Marvin Schmidt (6):
  docs: Remove stray HTML tags
  docs: Remove trailing whitespace
  docs: coding-style: Change full stop to colon
  docs: Markup LD_PRELOAD as code
  libcamera: ipa_module: Fix typo in function description
  libcamera: camera: Order parameter documentation correctly

 Documentation/coding-style.rst |  2 +-
 Documentation/docs.rst         | 10 +++++-----
 src/libcamera/camera.cpp       |  2 +-
 src/libcamera/ipa_module.cpp   |  2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)

Comments

Laurent Pinchart June 5, 2020, 6:50 a.m. UTC | #1 
Hi Marvin,

Thank you for the patches.

On Thu, Jun 04, 2020 at 03:42:54PM +0200, Marvin Schmidt wrote:
> Just a couple of fixes for minor documentation problems I stumpled upon while
> getting familiar with tne codebase.
> 
> Marvin Schmidt (6):
>   docs: Remove stray HTML tags
>   docs: Remove trailing whitespace
>   docs: coding-style: Change full stop to colon
>   docs: Markup LD_PRELOAD as code
>   libcamera: ipa_module: Fix typo in function description
>   libcamera: camera: Order parameter documentation correctly

For the whole series,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  Documentation/coding-style.rst |  2 +-
>  Documentation/docs.rst         | 10 +++++-----
>  src/libcamera/camera.cpp       |  2 +-
>  src/libcamera/ipa_module.cpp   |  2 +-
>  4 files changed, 8 insertions(+), 8 deletions(-)
>
Marvin Schmidt June 5, 2020, 8:21 a.m. UTC | #2 
Am Fr., 5. Juni 2020 um 08:51 Uhr schrieb Laurent Pinchart
<laurent.pinchart@ideasonboard.com>:
>
> Hi Marvin,
>
> Thank you for the patches.
>
> On Thu, Jun 04, 2020 at 03:42:54PM +0200, Marvin Schmidt wrote:
> > Just a couple of fixes for minor documentation problems I stumpled upon while
> > getting familiar with tne codebase.
> >
> > Marvin Schmidt (6):
> >   docs: Remove stray HTML tags
> >   docs: Remove trailing whitespace
> >   docs: coding-style: Change full stop to colon
> >   docs: Markup LD_PRELOAD as code
> >   libcamera: ipa_module: Fix typo in function description
> >   libcamera: camera: Order parameter documentation correctly
>
> For the whole series,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>

Hey Laurent,

thanks for reviewing, I'll send v2 with your and Kieran's R-b tags.

> >  Documentation/coding-style.rst |  2 +-
> >  Documentation/docs.rst         | 10 +++++-----
> >  src/libcamera/camera.cpp       |  2 +-
> >  src/libcamera/ipa_module.cpp   |  2 +-
> >  4 files changed, 8 insertions(+), 8 deletions(-)
> >
>
> --
> Regards,
>
> Laurent Pinchart