[libcamera-devel,v2] libcamera: media_device: fix typo in documentation for MediaDevice::deviceNode()

Message ID 20190122141929.20608-1-niklas.soderlund@ragnatech.se
State Accepted
Commit f10f1b8bb157973053aecc3176d089aae6e276fa
Headers show
Series
  • [libcamera-devel,v2] libcamera: media_device: fix typo in documentation for MediaDevice::deviceNode()
Related show

Commit Message

Niklas Söderlund Jan. 22, 2019, 2:19 p.m. UTC
Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
---
 src/libcamera/media_device.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kieran Bingham Jan. 22, 2019, 2:21 p.m. UTC | #1
Hi Niklas,

On 22/01/2019 14:19, Niklas Söderlund wrote:


"Remove duplicated word: 'device'" could go here in the commit message,
but it's not important.


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> ---
>  src/libcamera/media_device.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp
> index b12e71439a584f45..51e5088ebdd9afda 100644
> --- a/src/libcamera/media_device.cpp
> +++ b/src/libcamera/media_device.cpp
> @@ -287,7 +287,7 @@ int MediaDevice::populate()
>  
>  /**
>   * \fn MediaDevice::deviceNode()
> - * \brief Retrieve the media device device node path
> + * \brief Retrieve the media device node path
>   * \return The MediaDevice deviceNode path
>   */
>  
>
Jacopo Mondi Jan. 22, 2019, 2:23 p.m. UTC | #2
Hi Niklas

Acked-by: Jacopo Mondi <jacopo@jmondi.org>

please merge!

On Tue, Jan 22, 2019 at 03:19:29PM +0100, Niklas Söderlund wrote:
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> ---
>  src/libcamera/media_device.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp
> index b12e71439a584f45..51e5088ebdd9afda 100644
> --- a/src/libcamera/media_device.cpp
> +++ b/src/libcamera/media_device.cpp
> @@ -287,7 +287,7 @@ int MediaDevice::populate()
>
>  /**
>   * \fn MediaDevice::deviceNode()
> - * \brief Retrieve the media device device node path
> + * \brief Retrieve the media device node path
>   * \return The MediaDevice deviceNode path
>   */
>
> --
> 2.20.1
>
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel
Niklas Söderlund Jan. 22, 2019, 3:12 p.m. UTC | #3
Hello,

This patch have been merged.

On 2019-01-22 15:19:29 +0100, Niklas Söderlund wrote:
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> ---
>  src/libcamera/media_device.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp
> index b12e71439a584f45..51e5088ebdd9afda 100644
> --- a/src/libcamera/media_device.cpp
> +++ b/src/libcamera/media_device.cpp
> @@ -287,7 +287,7 @@ int MediaDevice::populate()
>  
>  /**
>   * \fn MediaDevice::deviceNode()
> - * \brief Retrieve the media device device node path
> + * \brief Retrieve the media device node path
>   * \return The MediaDevice deviceNode path
>   */
>  
> -- 
> 2.20.1
>

Patch

diff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp
index b12e71439a584f45..51e5088ebdd9afda 100644
--- a/src/libcamera/media_device.cpp
+++ b/src/libcamera/media_device.cpp
@@ -287,7 +287,7 @@  int MediaDevice::populate()
 
 /**
  * \fn MediaDevice::deviceNode()
- * \brief Retrieve the media device device node path
+ * \brief Retrieve the media device node path
  * \return The MediaDevice deviceNode path
  */