[libcamera-devel] libcamera: ipu3: Use log categories

Message ID 20190122133142.1165-1-jacopo@jmondi.org
State Accepted
Headers show
Series
  • [libcamera-devel] libcamera: ipu3: Use log categories
Related show

Commit Message

Jacopo Mondi Jan. 22, 2019, 1:31 p.m. UTC
Log the IPU3 pipeline using IPU3 log category

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 src/libcamera/pipeline/ipu3/ipu3.cpp | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

--
2.20.1

Comments

Niklas Söderlund Jan. 22, 2019, 1:43 p.m. UTC | #1
Hi Jacopo,

Thanks for your work.

On 2019-01-22 14:31:42 +0100, Jacopo Mondi wrote:
> Log the IPU3 pipeline using IPU3 log category
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>

> ---
>  src/libcamera/pipeline/ipu3/ipu3.cpp | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
> index daf681c..8cbc10a 100644
> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp
> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
> @@ -18,6 +18,8 @@
> 
>  namespace libcamera {
> 
> +LOG_DEFINE_CATEGORY(IPU3)
> +
>  class PipelineHandlerIPU3 : public PipelineHandler
>  {
>  public:
> @@ -172,9 +174,10 @@ void PipelineHandlerIPU3::registerCameras(CameraManager *manager)
>  		std::shared_ptr<Camera> camera = Camera::create(cameraName);
>  		manager->addCamera(std::move(camera));
> 
> -		LOG(Info) << "Registered Camera[" << numCameras << "] \""
> -			  << cameraName << "\""
> -			  << " connected to CSI-2 receiver " << id;
> +		LOG(IPU3, Info)
> +			<< "Registered Camera[" << numCameras << "] \""
> +			<< cameraName << "\""
> +			<< " connected to CSI-2 receiver " << id;
> 
>  		numCameras++;
>  	}
> --
> 2.20.1
> 
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch

diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp
index daf681c..8cbc10a 100644
--- a/src/libcamera/pipeline/ipu3/ipu3.cpp
+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp
@@ -18,6 +18,8 @@ 

 namespace libcamera {

+LOG_DEFINE_CATEGORY(IPU3)
+
 class PipelineHandlerIPU3 : public PipelineHandler
 {
 public:
@@ -172,9 +174,10 @@  void PipelineHandlerIPU3::registerCameras(CameraManager *manager)
 		std::shared_ptr<Camera> camera = Camera::create(cameraName);
 		manager->addCamera(std::move(camera));

-		LOG(Info) << "Registered Camera[" << numCameras << "] \""
-			  << cameraName << "\""
-			  << " connected to CSI-2 receiver " << id;
+		LOG(IPU3, Info)
+			<< "Registered Camera[" << numCameras << "] \""
+			<< cameraName << "\""
+			<< " connected to CSI-2 receiver " << id;

 		numCameras++;
 	}