[libcamera-devel,v5,0/7] libcamera: Add CameraSensorInfo
mbox series

Message ID 20200428091713.341322-1-jacopo@jmondi.org
Headers show
Series
  • libcamera: Add CameraSensorInfo
Related show

Message

Jacopo Mondi April 28, 2020, 9:17 a.m. UTC 
Hello,
   I intend to push this new version, rebased on the fast moving recent master,
as soon as the following patches on which this series depends on are merged:

libcamera: camera_sensor: Add model() function
libcamera: v4l2_device: Simplify usage of getControls()
libcamera: controls: Return ControlValue reference from ControlList::set()
libcamera: controls: Add rectangle and size control types

Laurent, as you're tha author, this:
libcamera: controls: Return ControlValue reference from ControlList::set()
is the only one that needs a small rework imho, all the rest is good to go.

Thanks
  j

Jacopo Mondi (7):
  libcamera: v4l2_subdevice: Expose setSelection()
  libcamera: v4l2_videodevice: Expose setSelection()
  libcamera: v4l2_subdevice: Implement getSelection()
  libcamera: camera_sensor: Define CameraSensorInfo
  libcamera: v4l2_subdevice: Add format information
  libcamera: camera_sensor: Add method to get sensor info
  libcamera: ipa: Add support for CameraSensorInfo

 include/ipa/ipa_interface.h                 |  27 ++-
 src/ipa/libipa/ipa_interface_wrapper.cpp    |  19 +-
 src/ipa/libipa/ipa_interface_wrapper.h      |   1 +
 src/ipa/rkisp1/rkisp1.cpp                   |  12 +-
 src/ipa/vimc/vimc.cpp                       |   3 +-
 src/libcamera/camera_sensor.cpp             | 143 ++++++++++++++
 src/libcamera/include/camera_sensor.h       |  14 ++
 src/libcamera/include/ipa_context_wrapper.h |   3 +-
 src/libcamera/include/v4l2_subdevice.h      |  11 +-
 src/libcamera/include/v4l2_videodevice.h    |   5 +-
 src/libcamera/ipa_context_wrapper.cpp       |  23 ++-
 src/libcamera/ipa_interface.cpp             |  73 +++++++
 src/libcamera/pipeline/ipu3/ipu3.cpp        |   4 +-
 src/libcamera/pipeline/rkisp1/rkisp1.cpp    |  10 +-
 src/libcamera/proxy/ipa_proxy_linux.cpp     |   3 +-
 src/libcamera/proxy/ipa_proxy_thread.cpp    |   8 +-
 src/libcamera/v4l2_subdevice.cpp            | 201 ++++++++++++++++----
 src/libcamera/v4l2_videodevice.cpp          |  20 +-
 test/ipa/ipa_wrappers_test.cpp              |  22 ++-
 19 files changed, 516 insertions(+), 86 deletions(-)

--
2.26.1

Comments

Laurent Pinchart April 28, 2020, 5:45 p.m. UTC | #1 
Hi Jacopo,

On Tue, Apr 28, 2020 at 11:17:13AM +0200, Jacopo Mondi wrote:
> Hello,
>    I intend to push this new version, rebased on the fast moving recent master,
> as soon as the following patches on which this series depends on are merged:
> 
> libcamera: camera_sensor: Add model() function
> libcamera: v4l2_device: Simplify usage of getControls()
> libcamera: controls: Return ControlValue reference from ControlList::set()
> libcamera: controls: Add rectangle and size control types
> 
> Laurent, as you're tha author, this:
> libcamera: controls: Return ControlValue reference from ControlList::set()
> is the only one that needs a small rework imho, all the rest is good to go.

I've pushed 

libcamera: v4l2_device: Simplify usage of getControls()
libcamera: controls: Add rectangle and size control types

and I'm working on a new version of

libcamera: camera_sensor: Add model() function

The other patch ("libcamera: controls: Return ControlValue reference
from ControlList::set()") isn't needed anymore.

> Jacopo Mondi (7):
>   libcamera: v4l2_subdevice: Expose setSelection()
>   libcamera: v4l2_videodevice: Expose setSelection()
>   libcamera: v4l2_subdevice: Implement getSelection()
>   libcamera: camera_sensor: Define CameraSensorInfo
>   libcamera: v4l2_subdevice: Add format information
>   libcamera: camera_sensor: Add method to get sensor info
>   libcamera: ipa: Add support for CameraSensorInfo
> 
>  include/ipa/ipa_interface.h                 |  27 ++-
>  src/ipa/libipa/ipa_interface_wrapper.cpp    |  19 +-
>  src/ipa/libipa/ipa_interface_wrapper.h      |   1 +
>  src/ipa/rkisp1/rkisp1.cpp                   |  12 +-
>  src/ipa/vimc/vimc.cpp                       |   3 +-
>  src/libcamera/camera_sensor.cpp             | 143 ++++++++++++++
>  src/libcamera/include/camera_sensor.h       |  14 ++
>  src/libcamera/include/ipa_context_wrapper.h |   3 +-
>  src/libcamera/include/v4l2_subdevice.h      |  11 +-
>  src/libcamera/include/v4l2_videodevice.h    |   5 +-
>  src/libcamera/ipa_context_wrapper.cpp       |  23 ++-
>  src/libcamera/ipa_interface.cpp             |  73 +++++++
>  src/libcamera/pipeline/ipu3/ipu3.cpp        |   4 +-
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp    |  10 +-
>  src/libcamera/proxy/ipa_proxy_linux.cpp     |   3 +-
>  src/libcamera/proxy/ipa_proxy_thread.cpp    |   8 +-
>  src/libcamera/v4l2_subdevice.cpp            | 201 ++++++++++++++++----
>  src/libcamera/v4l2_videodevice.cpp          |  20 +-
>  test/ipa/ipa_wrappers_test.cpp              |  22 ++-
>  19 files changed, 516 insertions(+), 86 deletions(-)