| Message ID | 20260323082000.1324115-3-barnabas.pocze@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Quoting Barnabás Pőcze (2026-03-23 08:19:55) > There are no other users of `egl.cpp`, so simplify by adding it to the > sources array at the same time. I think this sounds correct now, but I would anticipate this to change 'sometime'. I think the egl component should be used by the virtual pipeline handler to generate test patterns, or perhaps a dedicated test-pattern-generator object which could be shared across pipelines. I think additional pre- and post- processors would also be considered in other pipelines which would make use of the EGL component. A GPU Dewarp, a utility to do HDR merges ... But that's future-ware, so I don't object to this patch if you still want to do this. Acked-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > --- > src/libcamera/meson.build | 3 --- > src/libcamera/software_isp/meson.build | 1 + > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build > index c6c109a30..28ce93de6 100644 > --- a/src/libcamera/meson.build > +++ b/src/libcamera/meson.build > @@ -75,9 +75,6 @@ libegl = dependency('egl', required : false) > libglesv2 = dependency('glesv2', required : false) > > if mesa_works > - libcamera_internal_sources += files([ > - 'egl.cpp', > - ]) > gles_headless_enabled = true > else > gles_headless_enabled = false > diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build > index c61ac7d59..a55b76b58 100644 > --- a/src/libcamera/software_isp/meson.build > +++ b/src/libcamera/software_isp/meson.build > @@ -19,6 +19,7 @@ libcamera_internal_sources += files([ > if softisp_enabled and gles_headless_enabled > config_h.set('HAVE_DEBAYER_EGL', 1) > libcamera_internal_sources += files([ > + '../egl.cpp', > 'debayer_egl.cpp', > ]) > endif > -- > 2.53.0 >
diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build index c6c109a30..28ce93de6 100644 --- a/src/libcamera/meson.build +++ b/src/libcamera/meson.build @@ -75,9 +75,6 @@ libegl = dependency('egl', required : false) libglesv2 = dependency('glesv2', required : false) if mesa_works - libcamera_internal_sources += files([ - 'egl.cpp', - ]) gles_headless_enabled = true else gles_headless_enabled = false diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build index c61ac7d59..a55b76b58 100644 --- a/src/libcamera/software_isp/meson.build +++ b/src/libcamera/software_isp/meson.build @@ -19,6 +19,7 @@ libcamera_internal_sources += files([ if softisp_enabled and gles_headless_enabled config_h.set('HAVE_DEBAYER_EGL', 1) libcamera_internal_sources += files([ + '../egl.cpp', 'debayer_egl.cpp', ]) endif
There are no other users of `egl.cpp`, so simplify by adding it to the sources array at the same time. Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> --- src/libcamera/meson.build | 3 --- src/libcamera/software_isp/meson.build | 1 + 2 files changed, 1 insertion(+), 3 deletions(-)