| Message ID | 20260310120106.79922-6-johannes.goede@oss.qualcomm.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Hi, On 10-Mar-26 13:01, Hans de Goede wrote: > The software_isp.mode setting was missing from the runtime_configuration > documentation, add it. > > Reviewed-by: Milan Zamazal <mzamazal@redhat.com> > Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com> I forgot to pick up Kieran's Reviewed-by for v6 here, let me re-add that now: Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Regards, Hans > --- > Changes in v7: > - Move back to being part of the series, sorry for the confusion > > Changes in v6: > - Use "LIBCAMERA_SOFTISP_MODE, software_isp.mode" as item title > - Add Milan's Reviewed-by > - Send out as standalone patch, v5 of rest of series is ready as is > > Changes in v5: > - New patch in v5 of this series > --- > Documentation/runtime_configuration.rst | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/runtime_configuration.rst b/Documentation/runtime_configuration.rst > index 651929a4d..a95de2f43 100644 > --- a/Documentation/runtime_configuration.rst > +++ b/Documentation/runtime_configuration.rst > @@ -51,6 +51,7 @@ file structure: > measure: > skip: # non-negative integer, frames to skip initially > number: # non-negative integer, frames to measure > + mode: # cpu/gpu > threads: # integer >= 1, number of render threads to use, default 2 > > Configuration file example > @@ -85,6 +86,7 @@ Configuration file example > measure: > skip: 50 > number: 30 > + mode: gpu > threads: 2 > > List of variables and configuration options > @@ -141,6 +143,13 @@ LIBCAMERA_<NAME>_TUNING_FILE > > Example value: ``/usr/local/share/libcamera/ipa/rpi/vc4/custom_sensor.json`` > > +LIBCAMERA_SOFTISP_MODE, software_isp.mode > + Select if the software ISP should use GPU or CPU image processsing, > + one of ``cpu`` or ``gpu``. When set to ``gpu`` and EGL is not available > + the software ISP will automatically fall back to the CPU. > + > + Example value: ``gpu`` > + > pipelines.simple.supported_devices.driver, pipelines.simple.supported_devices.software_isp > Override whether software ISP is enabled for the given driver. >
diff --git a/Documentation/runtime_configuration.rst b/Documentation/runtime_configuration.rst index 651929a4d..a95de2f43 100644 --- a/Documentation/runtime_configuration.rst +++ b/Documentation/runtime_configuration.rst @@ -51,6 +51,7 @@ file structure: measure: skip: # non-negative integer, frames to skip initially number: # non-negative integer, frames to measure + mode: # cpu/gpu threads: # integer >= 1, number of render threads to use, default 2 Configuration file example @@ -85,6 +86,7 @@ Configuration file example measure: skip: 50 number: 30 + mode: gpu threads: 2 List of variables and configuration options @@ -141,6 +143,13 @@ LIBCAMERA_<NAME>_TUNING_FILE Example value: ``/usr/local/share/libcamera/ipa/rpi/vc4/custom_sensor.json`` +LIBCAMERA_SOFTISP_MODE, software_isp.mode + Select if the software ISP should use GPU or CPU image processsing, + one of ``cpu`` or ``gpu``. When set to ``gpu`` and EGL is not available + the software ISP will automatically fall back to the CPU. + + Example value: ``gpu`` + pipelines.simple.supported_devices.driver, pipelines.simple.supported_devices.software_isp Override whether software ISP is enabled for the given driver.