| Message ID | 20260304075052.11599-5-johannes.goede@oss.qualcomm.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi 2026. 03. 04. 8:50 keltezéssel, Hans de Goede írta: > As shown by commit 94d32fdc55a3 ("pipeline: simple: Consider output sizes > when choosing pipe config"), the extra pixel columns CPU debayering > requires on the input side makes resolution selection non trivial. > > Add logging of the selected input config on a successful configure() so > that the logs clearly show which sensor mode has been selected. > > Reviewed-by: Milan Zamazal <mzamazal@redhat.com> > Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com> > --- > Changes in v2: > - Move from DebayerCpu::configure() to SoftwareIsp::configure() so that > the input fmt also gets logged when using the DebayerEgl class > --- > src/libcamera/software_isp/software_isp.cpp | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp > index 562cdba22..4cf5639d9 100644 > --- a/src/libcamera/software_isp/software_isp.cpp > +++ b/src/libcamera/software_isp/software_isp.cpp > @@ -21,6 +21,7 @@ > #include <libcamera/formats.h> > #include <libcamera/stream.h> > > +#include "libcamera/internal/bayer_format.h" > #include "libcamera/internal/framebuffer.h" > #include "libcamera/internal/ipa_manager.h" > #include "libcamera/internal/software_isp/debayer_params.h" > @@ -270,7 +271,16 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg, > if (ret < 0) > return ret; > > - return debayer_->configure(inputCfg, outputCfgs, ccmEnabled_); > + ret = debayer_->configure(inputCfg, outputCfgs, ccmEnabled_); > + if (ret < 0) > + return ret; > + > + LOG(SoftwareIsp, Info) > + << "Input " << inputCfg.size > + << "-" << BayerFormat::fromPixelFormat(inputCfg.pixelFormat) > + << " stride " << inputCfg.stride; I feel like "INFO" is a bit too high for this, nonetheless: Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > + > + return 0; > } > > /**
diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp index 562cdba22..4cf5639d9 100644 --- a/src/libcamera/software_isp/software_isp.cpp +++ b/src/libcamera/software_isp/software_isp.cpp @@ -21,6 +21,7 @@ #include <libcamera/formats.h> #include <libcamera/stream.h> +#include "libcamera/internal/bayer_format.h" #include "libcamera/internal/framebuffer.h" #include "libcamera/internal/ipa_manager.h" #include "libcamera/internal/software_isp/debayer_params.h" @@ -270,7 +271,16 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg, if (ret < 0) return ret; - return debayer_->configure(inputCfg, outputCfgs, ccmEnabled_); + ret = debayer_->configure(inputCfg, outputCfgs, ccmEnabled_); + if (ret < 0) + return ret; + + LOG(SoftwareIsp, Info) + << "Input " << inputCfg.size + << "-" << BayerFormat::fromPixelFormat(inputCfg.pixelFormat) + << " stride " << inputCfg.stride; + + return 0; } /**
As shown by commit 94d32fdc55a3 ("pipeline: simple: Consider output sizes when choosing pipe config"), the extra pixel columns CPU debayering requires on the input side makes resolution selection non trivial. Add logging of the selected input config on a successful configure() so that the logs clearly show which sensor mode has been selected. Reviewed-by: Milan Zamazal <mzamazal@redhat.com> Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com> --- Changes in v2: - Move from DebayerCpu::configure() to SoftwareIsp::configure() so that the input fmt also gets logged when using the DebayerEgl class --- src/libcamera/software_isp/software_isp.cpp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)