[v6] Documentation/runtime_configuration: Add missing software_isp.mode doc
diff mbox series

Message ID 20260304110246.15191-1-johannes.goede@oss.qualcomm.com
State New
Headers show
Series
  • [v6] Documentation/runtime_configuration: Add missing software_isp.mode doc
Related show

Commit Message

Hans de Goede March 4, 2026, 11:02 a.m. UTC 
The software_isp.mode setting was missing from the runtime_configuration
documentation, add it.

Reviewed-by: Milan Zamazal <mzamazal@redhat.com>
Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
---
Changes in v6:
- Use "LIBCAMERA_SOFTISP_MODE, software_isp.mode" as item title
- Add Milan's Reviewed-by
- Send out as standalone patch, v5 of rest of series is ready as is

Changes in v5:
- New patch in v5 of this series
---
 Documentation/runtime_configuration.rst | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Kieran Bingham March 4, 2026, 11:59 a.m. UTC | #1 
Quoting Hans de Goede (2026-03-04 11:02:46)
> The software_isp.mode setting was missing from the runtime_configuration
> documentation, add it.

I guess this was part of another series ? Anyway lets just merge it!

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> 
> Reviewed-by: Milan Zamazal <mzamazal@redhat.com>
> Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
> ---
> Changes in v6:
> - Use "LIBCAMERA_SOFTISP_MODE, software_isp.mode" as item title
> - Add Milan's Reviewed-by
> - Send out as standalone patch, v5 of rest of series is ready as is
> 
> Changes in v5:
> - New patch in v5 of this series
> ---
>  Documentation/runtime_configuration.rst | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/runtime_configuration.rst b/Documentation/runtime_configuration.rst
> index 651929a4d..a95de2f43 100644
> --- a/Documentation/runtime_configuration.rst
> +++ b/Documentation/runtime_configuration.rst
> @@ -51,6 +51,7 @@ file structure:
>        measure:
>          skip: # non-negative integer, frames to skip initially
>          number: # non-negative integer, frames to measure
> +      mode: # cpu/gpu
>        threads: # integer >= 1, number of render threads to use, default 2
>  
>  Configuration file example
> @@ -85,6 +86,7 @@ Configuration file example
>         measure:
>           skip: 50
>           number: 30
> +       mode: gpu
>         threads: 2
>  
>  List of variables and configuration options
> @@ -141,6 +143,13 @@ LIBCAMERA_<NAME>_TUNING_FILE
>  
>     Example value: ``/usr/local/share/libcamera/ipa/rpi/vc4/custom_sensor.json``
>  
> +LIBCAMERA_SOFTISP_MODE, software_isp.mode
> +   Select if the software ISP should use GPU or CPU image processsing,
> +   one of ``cpu`` or ``gpu``. When set to ``gpu`` and EGL is not available
> +   the software ISP will automatically fall back to the CPU.
> +
> +   Example value: ``gpu``
> +
>  pipelines.simple.supported_devices.driver, pipelines.simple.supported_devices.software_isp
>     Override whether software ISP is enabled for the given driver.
>  
> -- 
> 2.52.0
>
Hans de Goede March 4, 2026, 12:19 p.m. UTC | #2 
Hi,

On 4-Mar-26 12:59 PM, Kieran Bingham wrote:
> Quoting Hans de Goede (2026-03-04 11:02:46)
>> The software_isp.mode setting was missing from the runtime_configuration
>> documentation, add it.
> 
> I guess this was part of another series ? Anyway lets just merge it!

Yes this was patch 5/5 of "[PATCH v5 0/5] software_isp: debayer_cpu: Add
multi-threading support" as also mentioned in the changelog below
the cut-line :)

Note this will not apply cleanly without first applying 1-4 of

https://patchwork.libcamera.org/project/libcamera/list/?series=5817

All 4 of those have a Reviewed-by from Milan, so from my pov those are
ready for merging too.

Regards,

Hans



> 
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 
>>
>> Reviewed-by: Milan Zamazal <mzamazal@redhat.com>
>> Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
>> ---
>> Changes in v6:
>> - Use "LIBCAMERA_SOFTISP_MODE, software_isp.mode" as item title
>> - Add Milan's Reviewed-by
>> - Send out as standalone patch, v5 of rest of series is ready as is
>>
>> Changes in v5:
>> - New patch in v5 of this series
>> ---
>>  Documentation/runtime_configuration.rst | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/runtime_configuration.rst b/Documentation/runtime_configuration.rst
>> index 651929a4d..a95de2f43 100644
>> --- a/Documentation/runtime_configuration.rst
>> +++ b/Documentation/runtime_configuration.rst
>> @@ -51,6 +51,7 @@ file structure:
>>        measure:
>>          skip: # non-negative integer, frames to skip initially
>>          number: # non-negative integer, frames to measure
>> +      mode: # cpu/gpu
>>        threads: # integer >= 1, number of render threads to use, default 2
>>  
>>  Configuration file example
>> @@ -85,6 +86,7 @@ Configuration file example
>>         measure:
>>           skip: 50
>>           number: 30
>> +       mode: gpu
>>         threads: 2
>>  
>>  List of variables and configuration options
>> @@ -141,6 +143,13 @@ LIBCAMERA_<NAME>_TUNING_FILE
>>  
>>     Example value: ``/usr/local/share/libcamera/ipa/rpi/vc4/custom_sensor.json``
>>  
>> +LIBCAMERA_SOFTISP_MODE, software_isp.mode
>> +   Select if the software ISP should use GPU or CPU image processsing,
>> +   one of ``cpu`` or ``gpu``. When set to ``gpu`` and EGL is not available
>> +   the software ISP will automatically fall back to the CPU.
>> +
>> +   Example value: ``gpu``
>> +
>>  pipelines.simple.supported_devices.driver, pipelines.simple.supported_devices.software_isp
>>     Override whether software ISP is enabled for the given driver.
>>  
>> -- 
>> 2.52.0
>>
Kieran Bingham March 4, 2026, 12:32 p.m. UTC | #3 
Quoting Hans de Goede (2026-03-04 12:19:15)
> Hi,
> 
> On 4-Mar-26 12:59 PM, Kieran Bingham wrote:
> > Quoting Hans de Goede (2026-03-04 11:02:46)
> >> The software_isp.mode setting was missing from the runtime_configuration
> >> documentation, add it.
> > 
> > I guess this was part of another series ? Anyway lets just merge it!
> 
> Yes this was patch 5/5 of "[PATCH v5 0/5] software_isp: debayer_cpu: Add
> multi-threading support" as also mentioned in the changelog below
> the cut-line :)
> 
> Note this will not apply cleanly without first applying 1-4 of
> 
> https://patchwork.libcamera.org/project/libcamera/list/?series=5817
> 
> All 4 of those have a Reviewed-by from Milan, so from my pov those are
> ready for merging too.

Aha, I missed that - but Ack.
--
Kieran

> 
> Regards,
> 
> Hans
> 
> 
> 
> > 
> > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> > 
> >>
> >> Reviewed-by: Milan Zamazal <mzamazal@redhat.com>
> >> Signed-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>
> >> ---
> >> Changes in v6:
> >> - Use "LIBCAMERA_SOFTISP_MODE, software_isp.mode" as item title
> >> - Add Milan's Reviewed-by
> >> - Send out as standalone patch, v5 of rest of series is ready as is
> >>
> >> Changes in v5:
> >> - New patch in v5 of this series
> >> ---
> >>  Documentation/runtime_configuration.rst | 9 +++++++++
> >>  1 file changed, 9 insertions(+)
> >>
> >> diff --git a/Documentation/runtime_configuration.rst b/Documentation/runtime_configuration.rst
> >> index 651929a4d..a95de2f43 100644
> >> --- a/Documentation/runtime_configuration.rst
> >> +++ b/Documentation/runtime_configuration.rst
> >> @@ -51,6 +51,7 @@ file structure:
> >>        measure:
> >>          skip: # non-negative integer, frames to skip initially
> >>          number: # non-negative integer, frames to measure
> >> +      mode: # cpu/gpu
> >>        threads: # integer >= 1, number of render threads to use, default 2
> >>  
> >>  Configuration file example
> >> @@ -85,6 +86,7 @@ Configuration file example
> >>         measure:
> >>           skip: 50
> >>           number: 30
> >> +       mode: gpu
> >>         threads: 2
> >>  
> >>  List of variables and configuration options
> >> @@ -141,6 +143,13 @@ LIBCAMERA_<NAME>_TUNING_FILE
> >>  
> >>     Example value: ``/usr/local/share/libcamera/ipa/rpi/vc4/custom_sensor.json``
> >>  
> >> +LIBCAMERA_SOFTISP_MODE, software_isp.mode
> >> +   Select if the software ISP should use GPU or CPU image processsing,
> >> +   one of ``cpu`` or ``gpu``. When set to ``gpu`` and EGL is not available
> >> +   the software ISP will automatically fall back to the CPU.
> >> +
> >> +   Example value: ``gpu``
> >> +
> >>  pipelines.simple.supported_devices.driver, pipelines.simple.supported_devices.software_isp
> >>     Override whether software ISP is enabled for the given driver.
> >>  
> >> -- 
> >> 2.52.0
> >>
>

Patch
diff mbox series 

diff --git a/Documentation/runtime_configuration.rst b/Documentation/runtime_configuration.rst
index 651929a4d..a95de2f43 100644
--- a/Documentation/runtime_configuration.rst
+++ b/Documentation/runtime_configuration.rst
@@ -51,6 +51,7 @@  file structure:
       measure:
         skip: # non-negative integer, frames to skip initially
         number: # non-negative integer, frames to measure
+      mode: # cpu/gpu
       threads: # integer >= 1, number of render threads to use, default 2
 
 Configuration file example
@@ -85,6 +86,7 @@  Configuration file example
        measure:
          skip: 50
          number: 30
+       mode: gpu
        threads: 2
 
 List of variables and configuration options
@@ -141,6 +143,13 @@  LIBCAMERA_<NAME>_TUNING_FILE
 
    Example value: ``/usr/local/share/libcamera/ipa/rpi/vc4/custom_sensor.json``
 
+LIBCAMERA_SOFTISP_MODE, software_isp.mode
+   Select if the software ISP should use GPU or CPU image processsing,
+   one of ``cpu`` or ``gpu``. When set to ``gpu`` and EGL is not available
+   the software ISP will automatically fall back to the CPU.
+
+   Example value: ``gpu``
+
 pipelines.simple.supported_devices.driver, pipelines.simple.supported_devices.software_isp
    Override whether software ISP is enabled for the given driver.