| Message ID | 20260302102540.824771-1-naush@raspberrypi.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
2026. 03. 02. 11:25 keltezéssel, Naushir Patuck írta: > The kDefaultCT variable is unused, remove it. > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > --- Possibly: Fixes: 045bfb1b8f0a ("ipa: rpi: controller: awb: Add Neural Network AWB") Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > src/ipa/rpi/controller/rpi/awb_nn.cpp | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/ipa/rpi/controller/rpi/awb_nn.cpp b/src/ipa/rpi/controller/rpi/awb_nn.cpp > index 1c20512638dd..c382f63d5f21 100644 > --- a/src/ipa/rpi/controller/rpi/awb_nn.cpp > +++ b/src/ipa/rpi/controller/rpi/awb_nn.cpp > @@ -35,8 +35,6 @@ using namespace libcamera; > > LOG_DECLARE_CATEGORY(RPiAwb) > > -constexpr double kDefaultCT = 4500.0; > - > /* > * The neural networks are trained to work on images rendered at a canonical > * colour temperature. That value is 5000K, which must be reproduced here.
Quoting Barnabás Pőcze (2026-03-02 10:37:26) > 2026. 03. 02. 11:25 keltezéssel, Naushir Patuck írta: > > The kDefaultCT variable is unused, remove it. > > > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com> > > --- > > Possibly: > > Fixes: 045bfb1b8f0a ("ipa: rpi: controller: awb: Add Neural Network AWB") That would then add this patch to the bug reports on the release notes, so I'd probably leave that out in this instance. Removing an unused variable probably doesn't cross the threshold into fixing a bug, but it's still a valid patch so: Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > > Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > > > > src/ipa/rpi/controller/rpi/awb_nn.cpp | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/src/ipa/rpi/controller/rpi/awb_nn.cpp b/src/ipa/rpi/controller/rpi/awb_nn.cpp > > index 1c20512638dd..c382f63d5f21 100644 > > --- a/src/ipa/rpi/controller/rpi/awb_nn.cpp > > +++ b/src/ipa/rpi/controller/rpi/awb_nn.cpp > > @@ -35,8 +35,6 @@ using namespace libcamera; > > > > LOG_DECLARE_CATEGORY(RPiAwb) > > > > -constexpr double kDefaultCT = 4500.0; > > - > > /* > > * The neural networks are trained to work on images rendered at a canonical > > * colour temperature. That value is 5000K, which must be reproduced here. >
diff --git a/src/ipa/rpi/controller/rpi/awb_nn.cpp b/src/ipa/rpi/controller/rpi/awb_nn.cpp index 1c20512638dd..c382f63d5f21 100644 --- a/src/ipa/rpi/controller/rpi/awb_nn.cpp +++ b/src/ipa/rpi/controller/rpi/awb_nn.cpp @@ -35,8 +35,6 @@ using namespace libcamera; LOG_DECLARE_CATEGORY(RPiAwb) -constexpr double kDefaultCT = 4500.0; - /* * The neural networks are trained to work on images rendered at a canonical * colour temperature. That value is 5000K, which must be reproduced here.
The kDefaultCT variable is unused, remove it. Signed-off-by: Naushir Patuck <naush@raspberrypi.com> --- src/ipa/rpi/controller/rpi/awb_nn.cpp | 2 -- 1 file changed, 2 deletions(-)