| Message ID | 20260224132415.269693-1-barnabas.pocze@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Barnabás Pőcze <barnabas.pocze@ideasonboard.com> writes: > The base class (`Debayer`) already contains a non-virtual function > with the same implementation, so remove it from the derived class. > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Reviewed-by: Milan Zamazal <mzamazal@redhat.com> > --- > src/libcamera/software_isp/debayer_egl.cpp | 10 ---------- > src/libcamera/software_isp/debayer_egl.h | 1 - > 2 files changed, 11 deletions(-) > > diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp > index 93f7c6946..8147eca1c 100644 > --- a/src/libcamera/software_isp/debayer_egl.cpp > +++ b/src/libcamera/software_isp/debayer_egl.cpp > @@ -276,16 +276,6 @@ int DebayerEGL::initBayerShaders(PixelFormat inputFormat, PixelFormat outputForm > return getShaderVariableLocations(); > } > > -/** > - * \brief Get the output frame size > - * > - * \return The output frame size > - */ > -unsigned int DebayerEGL::frameSize() > -{ > - return outputConfig_.frameSize; > -} > - > int DebayerEGL::configure(const StreamConfiguration &inputCfg, > const std::vector<std::reference_wrapper<StreamConfiguration>> &outputCfgs, > [[maybe_unused]] bool ccmEnabled) > diff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h > index 59aebcc81..d4c1fa31e 100644 > --- a/src/libcamera/software_isp/debayer_egl.h > +++ b/src/libcamera/software_isp/debayer_egl.h > @@ -55,7 +55,6 @@ public: > void stop(); > > const SharedFD &getStatsFD() { return stats_->getStatsFD(); } > - unsigned int frameSize(); > > SizeRange sizes(PixelFormat inputFormat, const Size &inputSize);
Hi Barnabás, Thank you for the patch! Quoting Barnabás Pőcze (2026-02-24 13:24:15) > The base class (`Debayer`) already contains a non-virtual function > with the same implementation, so remove it from the derived class. > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > --- > src/libcamera/software_isp/debayer_egl.cpp | 10 ---------- > src/libcamera/software_isp/debayer_egl.h | 1 - > 2 files changed, 11 deletions(-) > > diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp > index 93f7c6946..8147eca1c 100644 > --- a/src/libcamera/software_isp/debayer_egl.cpp > +++ b/src/libcamera/software_isp/debayer_egl.cpp > @@ -276,16 +276,6 @@ int DebayerEGL::initBayerShaders(PixelFormat inputFormat, PixelFormat outputForm > return getShaderVariableLocations(); > } > > -/** > - * \brief Get the output frame size > - * > - * \return The output frame size > - */ > -unsigned int DebayerEGL::frameSize() > -{ > - return outputConfig_.frameSize; > -} > - > int DebayerEGL::configure(const StreamConfiguration &inputCfg, > const std::vector<std::reference_wrapper<StreamConfiguration>> &outputCfgs, > [[maybe_unused]] bool ccmEnabled) > diff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h > index 59aebcc81..d4c1fa31e 100644 > --- a/src/libcamera/software_isp/debayer_egl.h > +++ b/src/libcamera/software_isp/debayer_egl.h > @@ -55,7 +55,6 @@ public: > void stop(); > > const SharedFD &getStatsFD() { return stats_->getStatsFD(); } > - unsigned int frameSize(); Reviewed-by: Isaac Scott <isaac.scott@ideasonboard.com> Best wishes, Isaac > > SizeRange sizes(PixelFormat inputFormat, const Size &inputSize); > > -- > 2.53.0 >
Hi, On 24-Feb-26 14:24, Barnabás Pőcze wrote: > The base class (`Debayer`) already contains a non-virtual function > with the same implementation, so remove it from the derived class. > > Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com> Regards, Hans > --- > src/libcamera/software_isp/debayer_egl.cpp | 10 ---------- > src/libcamera/software_isp/debayer_egl.h | 1 - > 2 files changed, 11 deletions(-) > > diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp > index 93f7c6946..8147eca1c 100644 > --- a/src/libcamera/software_isp/debayer_egl.cpp > +++ b/src/libcamera/software_isp/debayer_egl.cpp > @@ -276,16 +276,6 @@ int DebayerEGL::initBayerShaders(PixelFormat inputFormat, PixelFormat outputForm > return getShaderVariableLocations(); > } > > -/** > - * \brief Get the output frame size > - * > - * \return The output frame size > - */ > -unsigned int DebayerEGL::frameSize() > -{ > - return outputConfig_.frameSize; > -} > - > int DebayerEGL::configure(const StreamConfiguration &inputCfg, > const std::vector<std::reference_wrapper<StreamConfiguration>> &outputCfgs, > [[maybe_unused]] bool ccmEnabled) > diff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h > index 59aebcc81..d4c1fa31e 100644 > --- a/src/libcamera/software_isp/debayer_egl.h > +++ b/src/libcamera/software_isp/debayer_egl.h > @@ -55,7 +55,6 @@ public: > void stop(); > > const SharedFD &getStatsFD() { return stats_->getStatsFD(); } > - unsigned int frameSize(); > > SizeRange sizes(PixelFormat inputFormat, const Size &inputSize); >
diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp index 93f7c6946..8147eca1c 100644 --- a/src/libcamera/software_isp/debayer_egl.cpp +++ b/src/libcamera/software_isp/debayer_egl.cpp @@ -276,16 +276,6 @@ int DebayerEGL::initBayerShaders(PixelFormat inputFormat, PixelFormat outputForm return getShaderVariableLocations(); } -/** - * \brief Get the output frame size - * - * \return The output frame size - */ -unsigned int DebayerEGL::frameSize() -{ - return outputConfig_.frameSize; -} - int DebayerEGL::configure(const StreamConfiguration &inputCfg, const std::vector<std::reference_wrapper<StreamConfiguration>> &outputCfgs, [[maybe_unused]] bool ccmEnabled) diff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h index 59aebcc81..d4c1fa31e 100644 --- a/src/libcamera/software_isp/debayer_egl.h +++ b/src/libcamera/software_isp/debayer_egl.h @@ -55,7 +55,6 @@ public: void stop(); const SharedFD &getStatsFD() { return stats_->getStatsFD(); } - unsigned int frameSize(); SizeRange sizes(PixelFormat inputFormat, const Size &inputSize);
The base class (`Debayer`) already contains a non-virtual function with the same implementation, so remove it from the derived class. Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> --- src/libcamera/software_isp/debayer_egl.cpp | 10 ---------- src/libcamera/software_isp/debayer_egl.h | 1 - 2 files changed, 11 deletions(-)