[v7,07/15] ipa: rkisp1: cproc: Report metadata

26149 diff mbox series

Presently the colour processing component exposes controls for
brightness, saturation, and contrast to the applications which are
handled and processed accordingly on the ISP.

The implementation lacks reporting the values that are set back to the
application.

Utilise the new Quantised types to provide the values that were applied
to the hardware and report them in the completed request metadata.

Reviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>
Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

---

v5:
- Fix line wraps
---
 src/ipa/rkisp1/algorithms/cproc.cpp | 14 ++++++++++++++
 src/ipa/rkisp1/algorithms/cproc.h   |  4 ++++
 2 files changed, 18 insertions(+)

Quoting Kieran Bingham (2026-02-14 01:57:46)
> Presently the colour processing component exposes controls for
> brightness, saturation, and contrast to the applications which are
> handled and processed accordingly on the ISP.
> 
> The implementation lacks reporting the values that are set back to the
> application.
> 
> Utilise the new Quantised types to provide the values that were applied
> to the hardware and report them in the completed request metadata.
> 
> Reviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>
> Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> 
> ---
> 
> v5:
> - Fix line wraps
> ---
>  src/ipa/rkisp1/algorithms/cproc.cpp | 14 ++++++++++++++
>  src/ipa/rkisp1/algorithms/cproc.h   |  4 ++++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/src/ipa/rkisp1/algorithms/cproc.cpp b/src/ipa/rkisp1/algorithms/cproc.cpp
> index 4374c08c2a4f..e9e2b5444bc9 100644
> --- a/src/ipa/rkisp1/algorithms/cproc.cpp
> +++ b/src/ipa/rkisp1/algorithms/cproc.cpp
> @@ -143,6 +143,20 @@ void ColorProcessing::prepare([[maybe_unused]] IPAContext &context,
>         config->sat = frameContext.cproc.saturation.quantized();
>  }
>  
> +/**
> + * \copydoc libcamera::ipa::Algorithm::process
> + */
> +void ColorProcessing::process([[maybe_unused]] IPAContext &context,
> +                             [[maybe_unused]] const uint32_t frame,
> +                             IPAFrameContext &frameContext,
> +                             [[maybe_unused]] const rkisp1_stat_buffer *stats,
> +                             ControlList &metadata)
> +{
> +       metadata.set(controls::Brightness, frameContext.cproc.brightness.value());
> +       metadata.set(controls::Contrast, frameContext.cproc.contrast.value());
> +       metadata.set(controls::Saturation, frameContext.cproc.saturation.value());
> +}
> +
>  REGISTER_IPA_ALGORITHM(ColorProcessing, "ColorProcessing")
>  
>  } /* namespace ipa::rkisp1::algorithms */
> diff --git a/src/ipa/rkisp1/algorithms/cproc.h b/src/ipa/rkisp1/algorithms/cproc.h
> index fd38fd17e8bb..9b589ebd4ad7 100644
> --- a/src/ipa/rkisp1/algorithms/cproc.h
> +++ b/src/ipa/rkisp1/algorithms/cproc.h
> @@ -30,6 +30,10 @@ public:
>         void prepare(IPAContext &context, const uint32_t frame,
>                      IPAFrameContext &frameContext,
>                      RkISP1Params *params) override;
> +       void process(IPAContext &context, const uint32_t frame,
> +                    IPAFrameContext &frameContext,
> +                    const rkisp1_stat_buffer *stats,
> +                    ControlList &metadata) override;
>  };
>  
>  } /* namespace ipa::rkisp1::algorithms */
> 
> -- 
> 2.52.0
>