| Message ID | 20260204-kbingham-fixups-v2-1-c341cced1fad@ideasonboard.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Kieran On Wed, Feb 04, 2026 at 10:42:56PM +0000, Kieran Bingham wrote: > The Awb brief was not updated from when the Bayes AWB was added. > > Extend it to account for this. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Thanks j > --- > src/ipa/rkisp1/algorithms/awb.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp > index e8da7974a1d6ad9ec2e22c6b013aead0a88ee1c3..f83da545be856c08cd758dc20a5ace91344101cf 100644 > --- a/src/ipa/rkisp1/algorithms/awb.cpp > +++ b/src/ipa/rkisp1/algorithms/awb.cpp > @@ -30,7 +30,7 @@ namespace ipa::rkisp1::algorithms { > > /** > * \class Awb > - * \brief A Grey world white balance correction algorithm > + * \brief Manage the white balance with automatic and manual controls > */ > > LOG_DEFINE_CATEGORY(RkISP1Awb) > > -- > 2.52.0 >
2026. 02. 04. 23:42 keltezéssel, Kieran Bingham írta: > The Awb brief was not updated from when the Bayes AWB was added. > > Extend it to account for this. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- Looks ok to me. Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com> > src/ipa/rkisp1/algorithms/awb.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp > index e8da7974a1d6ad9ec2e22c6b013aead0a88ee1c3..f83da545be856c08cd758dc20a5ace91344101cf 100644 > --- a/src/ipa/rkisp1/algorithms/awb.cpp > +++ b/src/ipa/rkisp1/algorithms/awb.cpp > @@ -30,7 +30,7 @@ namespace ipa::rkisp1::algorithms { > > /** > * \class Awb > - * \brief A Grey world white balance correction algorithm > + * \brief Manage the white balance with automatic and manual controls > */ > > LOG_DEFINE_CATEGORY(RkISP1Awb) >
Kieran Bingham <kieran.bingham@ideasonboard.com> writes: > The Awb brief was not updated from when the Bayes AWB was added. > > Extend it to account for this. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Milan Zamazal <mzamazal@redhat.com> > --- > src/ipa/rkisp1/algorithms/awb.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp > index e8da7974a1d6ad9ec2e22c6b013aead0a88ee1c3..f83da545be856c08cd758dc20a5ace91344101cf 100644 > --- a/src/ipa/rkisp1/algorithms/awb.cpp > +++ b/src/ipa/rkisp1/algorithms/awb.cpp > @@ -30,7 +30,7 @@ namespace ipa::rkisp1::algorithms { > > /** > * \class Awb > - * \brief A Grey world white balance correction algorithm > + * \brief Manage the white balance with automatic and manual controls > */ > > LOG_DEFINE_CATEGORY(RkISP1Awb)
diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp index e8da7974a1d6ad9ec2e22c6b013aead0a88ee1c3..f83da545be856c08cd758dc20a5ace91344101cf 100644 --- a/src/ipa/rkisp1/algorithms/awb.cpp +++ b/src/ipa/rkisp1/algorithms/awb.cpp @@ -30,7 +30,7 @@ namespace ipa::rkisp1::algorithms { /** * \class Awb - * \brief A Grey world white balance correction algorithm + * \brief Manage the white balance with automatic and manual controls */ LOG_DEFINE_CATEGORY(RkISP1Awb)
The Awb brief was not updated from when the Bayes AWB was added. Extend it to account for this. Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- src/ipa/rkisp1/algorithms/awb.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)