[3/3] ipa: simple: Remove duplicate header inclusion
diff mbox series

Message ID 20260202-kbingham-fixups-v1-3-7d7dd4b2a27b@ideasonboard.com
State Superseded
Headers show
Series
  • ipa: awb: Fix and cleanup RKISP1 and Simple Awb
Related show

Commit Message

Kieran Bingham Feb. 2, 2026, 7:25 p.m. UTC
The Awb component already references libcamera/control_ids.h. Remove
the incorrect duplicate inclusion of "control_ids.h".

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 src/ipa/simple/algorithms/awb.cpp | 2 --
 1 file changed, 2 deletions(-)

Comments

Milan Zamazal Feb. 2, 2026, 8 p.m. UTC | #1
Kieran Bingham <kieran.bingham@ideasonboard.com> writes:

> The Awb component already references libcamera/control_ids.h. Remove
> the incorrect duplicate inclusion of "control_ids.h".
>
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Milan Zamazal <mzamazal@redhat.com>

> ---
>  src/ipa/simple/algorithms/awb.cpp | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp
> index 6fdaacaba3183bc2efa348c4182b90201006b826..6369193c686c0c69de88cb60756a00557dbdbbd9 100644
> --- a/src/ipa/simple/algorithms/awb.cpp
> +++ b/src/ipa/simple/algorithms/awb.cpp
> @@ -17,8 +17,6 @@
>  #include "libipa/colours.h"
>  #include "simple/ipa_context.h"
>  
> -#include "control_ids.h"
> -
>  namespace libcamera {
>  
>  LOG_DEFINE_CATEGORY(IPASoftAwb)
Barnabás Pőcze Feb. 3, 2026, 8:20 a.m. UTC | #2
2026. 02. 02. 20:25 keltezéssel, Kieran Bingham írta:
> The Awb component already references libcamera/control_ids.h. Remove
> the incorrect duplicate inclusion of "control_ids.h".
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>


>   src/ipa/simple/algorithms/awb.cpp | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp
> index 6fdaacaba3183bc2efa348c4182b90201006b826..6369193c686c0c69de88cb60756a00557dbdbbd9 100644
> --- a/src/ipa/simple/algorithms/awb.cpp
> +++ b/src/ipa/simple/algorithms/awb.cpp
> @@ -17,8 +17,6 @@
>   #include "libipa/colours.h"
>   #include "simple/ipa_context.h"
>   
> -#include "control_ids.h"
> -
>   namespace libcamera {
>   
>   LOG_DEFINE_CATEGORY(IPASoftAwb)
>

Patch
diff mbox series

diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp
index 6fdaacaba3183bc2efa348c4182b90201006b826..6369193c686c0c69de88cb60756a00557dbdbbd9 100644
--- a/src/ipa/simple/algorithms/awb.cpp
+++ b/src/ipa/simple/algorithms/awb.cpp
@@ -17,8 +17,6 @@ 
 #include "libipa/colours.h"
 #include "simple/ipa_context.h"
 
-#include "control_ids.h"
-
 namespace libcamera {
 
 LOG_DEFINE_CATEGORY(IPASoftAwb)