| Message ID | 20260202-kbingham-fixups-v1-1-7d7dd4b2a27b@ideasonboard.com |
|---|---|
| State | New |
| Headers | show |
| Series |
|
| Related | show |
Hi Kieran, Kieran Bingham <kieran.bingham@ideasonboard.com> writes: > The Awb brief was not updated from when the Bayes AWB was added. > > Extend it to account for this. > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > src/ipa/rkisp1/algorithms/awb.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp > index e8da7974a1d6ad9ec2e22c6b013aead0a88ee1c3..452ee878f4b3dac99586556e2c3ac7c73cada2b3 100644 > --- a/src/ipa/rkisp1/algorithms/awb.cpp > +++ b/src/ipa/rkisp1/algorithms/awb.cpp > @@ -30,7 +30,7 @@ namespace ipa::rkisp1::algorithms { > > /** > * \class Awb > - * \brief A Grey world white balance correction algorithm > + * \brief Process the RKISP1 AWB statistics for AwbGrey and AwbBayes How about not listing the particular algorithms at all, so that it needn't be updated when algorithms are added? > */ > > LOG_DEFINE_CATEGORY(RkISP1Awb)
Quoting Milan Zamazal (2026-02-02 19:48:43) > Hi Kieran, > > Kieran Bingham <kieran.bingham@ideasonboard.com> writes: > > > The Awb brief was not updated from when the Bayes AWB was added. > > > > Extend it to account for this. > > > > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > > --- > > src/ipa/rkisp1/algorithms/awb.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp > > index e8da7974a1d6ad9ec2e22c6b013aead0a88ee1c3..452ee878f4b3dac99586556e2c3ac7c73cada2b3 100644 > > --- a/src/ipa/rkisp1/algorithms/awb.cpp > > +++ b/src/ipa/rkisp1/algorithms/awb.cpp > > @@ -30,7 +30,7 @@ namespace ipa::rkisp1::algorithms { > > > > /** > > * \class Awb > > - * \brief A Grey world white balance correction algorithm > > + * \brief Process the RKISP1 AWB statistics for AwbGrey and AwbBayes > > How about not listing the particular algorithms at all, so that it > needn't be updated when algorithms are added? How about just; \brief Manage the white balance with automatic and manual controls > > > */ > > > > LOG_DEFINE_CATEGORY(RkISP1Awb) >
Kieran Bingham <kieran.bingham@ideasonboard.com> writes: > Quoting Milan Zamazal (2026-02-02 19:48:43) >> Hi Kieran, >> > >> Kieran Bingham <kieran.bingham@ideasonboard.com> writes: >> >> > The Awb brief was not updated from when the Bayes AWB was added. >> > >> > Extend it to account for this. >> > >> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> >> > --- >> > src/ipa/rkisp1/algorithms/awb.cpp | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp >> > index e8da7974a1d6ad9ec2e22c6b013aead0a88ee1c3..452ee878f4b3dac99586556e2c3ac7c73cada2b3 100644 >> > --- a/src/ipa/rkisp1/algorithms/awb.cpp >> > +++ b/src/ipa/rkisp1/algorithms/awb.cpp >> > @@ -30,7 +30,7 @@ namespace ipa::rkisp1::algorithms { >> > >> > /** >> > * \class Awb >> > - * \brief A Grey world white balance correction algorithm >> > + * \brief Process the RKISP1 AWB statistics for AwbGrey and AwbBayes >> >> How about not listing the particular algorithms at all, so that it >> needn't be updated when algorithms are added? > > How about just; > > \brief Manage the white balance with automatic and manual controls Looks good to me. >> > */ >> > >> > LOG_DEFINE_CATEGORY(RkISP1Awb) >>
diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp index e8da7974a1d6ad9ec2e22c6b013aead0a88ee1c3..452ee878f4b3dac99586556e2c3ac7c73cada2b3 100644 --- a/src/ipa/rkisp1/algorithms/awb.cpp +++ b/src/ipa/rkisp1/algorithms/awb.cpp @@ -30,7 +30,7 @@ namespace ipa::rkisp1::algorithms { /** * \class Awb - * \brief A Grey world white balance correction algorithm + * \brief Process the RKISP1 AWB statistics for AwbGrey and AwbBayes */ LOG_DEFINE_CATEGORY(RkISP1Awb)
The Awb brief was not updated from when the Bayes AWB was added. Extend it to account for this. Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com> --- src/ipa/rkisp1/algorithms/awb.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)