[v1,3/7] meson: Simplify condition
diff mbox series

Message ID 20260129164032.1380169-3-barnabas.pocze@ideasonboard.com
State New
Headers show
Series
  • [v1,1/7] meson: Drop unnecessary egl, gles feature defines
Related show

Commit Message

Barnabás Pőcze Jan. 29, 2026, 4:40 p.m. UTC
If `softisp_enabled` is false, then `subdir_done()` is called above.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/libcamera/software_isp/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Milan Zamazal Jan. 30, 2026, 1:08 p.m. UTC | #1
Barnabás Pőcze <barnabas.pocze@ideasonboard.com> writes:

> If `softisp_enabled` is false, then `subdir_done()` is called above.
>
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Reviewed-by: Milan Zamazal <mzamazal@redhat.com>

> ---
>  src/libcamera/software_isp/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build
> index a55b76b58..4c61909fd 100644
> --- a/src/libcamera/software_isp/meson.build
> +++ b/src/libcamera/software_isp/meson.build
> @@ -16,7 +16,7 @@ libcamera_internal_sources += files([
>      'swstats_cpu.cpp',
>  ])
>  
> -if softisp_enabled and gles_headless_enabled
> +if gles_headless_enabled
>      config_h.set('HAVE_DEBAYER_EGL', 1)
>      libcamera_internal_sources += files([
>          '../egl.cpp',
Laurent Pinchart Jan. 30, 2026, 2:02 p.m. UTC | #2
On Thu, Jan 29, 2026 at 05:40:28PM +0100, Barnabás Pőcze wrote:
> If `softisp_enabled` is false, then `subdir_done()` is called above.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/software_isp/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build
> index a55b76b58..4c61909fd 100644
> --- a/src/libcamera/software_isp/meson.build
> +++ b/src/libcamera/software_isp/meson.build
> @@ -16,7 +16,7 @@ libcamera_internal_sources += files([
>      'swstats_cpu.cpp',
>  ])
>  
> -if softisp_enabled and gles_headless_enabled
> +if gles_headless_enabled
>      config_h.set('HAVE_DEBAYER_EGL', 1)
>      libcamera_internal_sources += files([
>          '../egl.cpp',

Patch
diff mbox series

diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build
index a55b76b58..4c61909fd 100644
--- a/src/libcamera/software_isp/meson.build
+++ b/src/libcamera/software_isp/meson.build
@@ -16,7 +16,7 @@  libcamera_internal_sources += files([
     'swstats_cpu.cpp',
 ])
 
-if softisp_enabled and gles_headless_enabled
+if gles_headless_enabled
     config_h.set('HAVE_DEBAYER_EGL', 1)
     libcamera_internal_sources += files([
         '../egl.cpp',