[v1,1/7] meson: Drop unnecessary egl, gles feature defines
diff mbox series

Message ID 20260129164032.1380169-1-barnabas.pocze@ideasonboard.com
State New
Headers show
Series
  • [v1,1/7] meson: Drop unnecessary egl, gles feature defines
Related show

Commit Message

Barnabás Pőcze Jan. 29, 2026, 4:40 p.m. UTC 
`HAVE_LIBEGL` and `HAVE_GLESV2` are not used, so drop them.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/libcamera/meson.build | 8 --------
 1 file changed, 8 deletions(-)

Comments

Milan Zamazal Jan. 30, 2026, 12:58 p.m. UTC | #1 
Barnabás Pőcze <barnabas.pocze@ideasonboard.com> writes:

> `HAVE_LIBEGL` and `HAVE_GLESV2` are not used, so drop them.
>
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Reviewed-by: Milan Zamazal <mzamazal@redhat.com>

> ---
>  src/libcamera/meson.build | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> index d15943586..c6c109a30 100644
> --- a/src/libcamera/meson.build
> +++ b/src/libcamera/meson.build
> @@ -74,14 +74,6 @@ mesa_works = cc.check_header('EGL/egl.h', required: false)
>  libegl = dependency('egl', required : false)
>  libglesv2 = dependency('glesv2', required : false)
>  
> -if libegl.found()
> -    config_h.set('HAVE_LIBEGL', 1)
> -endif
> -
> -if libglesv2.found()
> -    config_h.set('HAVE_GLESV2', 1)
> -endif
> -
>  if mesa_works
>      libcamera_internal_sources += files([
>          'egl.cpp',
Laurent Pinchart Jan. 30, 2026, 2 p.m. UTC | #2 
On Thu, Jan 29, 2026 at 05:40:26PM +0100, Barnabás Pőcze wrote:
> `HAVE_LIBEGL` and `HAVE_GLESV2` are not used, so drop them.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/meson.build | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> index d15943586..c6c109a30 100644
> --- a/src/libcamera/meson.build
> +++ b/src/libcamera/meson.build
> @@ -74,14 +74,6 @@ mesa_works = cc.check_header('EGL/egl.h', required: false)
>  libegl = dependency('egl', required : false)
>  libglesv2 = dependency('glesv2', required : false)
>  
> -if libegl.found()
> -    config_h.set('HAVE_LIBEGL', 1)
> -endif
> -
> -if libglesv2.found()
> -    config_h.set('HAVE_GLESV2', 1)
> -endif
> -
>  if mesa_works
>      libcamera_internal_sources += files([
>          'egl.cpp',

Patch
diff mbox series 

diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
index d15943586..c6c109a30 100644
--- a/src/libcamera/meson.build
+++ b/src/libcamera/meson.build
@@ -74,14 +74,6 @@  mesa_works = cc.check_header('EGL/egl.h', required: false)
 libegl = dependency('egl', required : false)
 libglesv2 = dependency('glesv2', required : false)
 
-if libegl.found()
-    config_h.set('HAVE_LIBEGL', 1)
-endif
-
-if libglesv2.found()
-    config_h.set('HAVE_GLESV2', 1)
-endif
-
 if mesa_works
     libcamera_internal_sources += files([
         'egl.cpp',