[v1] libcamera: base: Add missing `private.h` includes
diff mbox series

Message ID 20260129102911.1200364-1-barnabas.pocze@ideasonboard.com
State New
Headers show
Series
  • [v1] libcamera: base: Add missing `private.h` includes
Related show

Commit Message

Barnabás Pőcze Jan. 29, 2026, 10:29 a.m. UTC
Certain private header files failed to include `private.h`, fix that.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 include/libcamera/base/memfd.h | 2 ++
 include/libcamera/base/regex.h | 2 ++
 2 files changed, 4 insertions(+)

Comments

Laurent Pinchart Jan. 29, 2026, 10:57 a.m. UTC | #1
On Thu, Jan 29, 2026 at 11:29:11AM +0100, Barnabás Pőcze wrote:
> Certain private header files failed to include `private.h`, fix that.
> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  include/libcamera/base/memfd.h | 2 ++
>  include/libcamera/base/regex.h | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/include/libcamera/base/memfd.h b/include/libcamera/base/memfd.h
> index 705d9929e..5ffa0f227 100644
> --- a/include/libcamera/base/memfd.h
> +++ b/include/libcamera/base/memfd.h
> @@ -7,6 +7,8 @@
>  
>  #pragma once
>  
> +#include <libcamera/base/private.h>
> +
>  #include <libcamera/base/flags.h>
>  #include <libcamera/base/unique_fd.h>
>  
> diff --git a/include/libcamera/base/regex.h b/include/libcamera/base/regex.h
> index 1ae21c1f9..45f4da8cb 100644
> --- a/include/libcamera/base/regex.h
> +++ b/include/libcamera/base/regex.h
> @@ -5,6 +5,8 @@
>   * std::regex wrapper for gcc
>   */
>  
> +#include <libcamera/base/private.h>
> +
>  #pragma GCC diagnostic push
>  #if defined __SANITIZE_ADDRESS__ && defined __OPTIMIZE__
>  #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
Kieran Bingham Jan. 29, 2026, 2:32 p.m. UTC | #2
Quoting Barnabás Pőcze (2026-01-29 10:29:11)
> Certain private header files failed to include `private.h`, fix that.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> 
> Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
> ---
>  include/libcamera/base/memfd.h | 2 ++
>  include/libcamera/base/regex.h | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/include/libcamera/base/memfd.h b/include/libcamera/base/memfd.h
> index 705d9929e..5ffa0f227 100644
> --- a/include/libcamera/base/memfd.h
> +++ b/include/libcamera/base/memfd.h
> @@ -7,6 +7,8 @@
>  
>  #pragma once
>  
> +#include <libcamera/base/private.h>
> +
>  #include <libcamera/base/flags.h>
>  #include <libcamera/base/unique_fd.h>
>  
> diff --git a/include/libcamera/base/regex.h b/include/libcamera/base/regex.h
> index 1ae21c1f9..45f4da8cb 100644
> --- a/include/libcamera/base/regex.h
> +++ b/include/libcamera/base/regex.h
> @@ -5,6 +5,8 @@
>   * std::regex wrapper for gcc
>   */
>  
> +#include <libcamera/base/private.h>
> +
>  #pragma GCC diagnostic push
>  #if defined __SANITIZE_ADDRESS__ && defined __OPTIMIZE__
>  #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
> -- 
> 2.52.0
>

Patch
diff mbox series

diff --git a/include/libcamera/base/memfd.h b/include/libcamera/base/memfd.h
index 705d9929e..5ffa0f227 100644
--- a/include/libcamera/base/memfd.h
+++ b/include/libcamera/base/memfd.h
@@ -7,6 +7,8 @@ 
 
 #pragma once
 
+#include <libcamera/base/private.h>
+
 #include <libcamera/base/flags.h>
 #include <libcamera/base/unique_fd.h>
 
diff --git a/include/libcamera/base/regex.h b/include/libcamera/base/regex.h
index 1ae21c1f9..45f4da8cb 100644
--- a/include/libcamera/base/regex.h
+++ b/include/libcamera/base/regex.h
@@ -5,6 +5,8 @@ 
  * std::regex wrapper for gcc
  */
 
+#include <libcamera/base/private.h>
+
 #pragma GCC diagnostic push
 #if defined __SANITIZE_ADDRESS__ && defined __OPTIMIZE__
 #pragma GCC diagnostic ignored "-Wmaybe-uninitialized"