[v4,13/15] libcamera: ipa: simple: Set contrast metadata unconditionally
diff mbox series

Message ID 20260122161935.208562-14-mzamazal@redhat.com
State Superseded
Headers show
Series
  • Simple pipeline IPA cleanup
Related show

Commit Message

Milan Zamazal Jan. 22, 2026, 4:19 p.m. UTC 
Let's do the same with contrast as with other metadata.

Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
---
 src/ipa/simple/algorithms/adjust.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Barnabás Pőcze Jan. 26, 2026, 2:48 p.m. UTC | #1 
2026. 01. 22. 17:19 keltezéssel, Milan Zamazal írta:
> Let's do the same with contrast as with other metadata.
> 
> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
> ---

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>


>   src/ipa/simple/algorithms/adjust.cpp | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/ipa/simple/algorithms/adjust.cpp b/src/ipa/simple/algorithms/adjust.cpp
> index 23f6f6ad7..acdd3f741 100644
> --- a/src/ipa/simple/algorithms/adjust.cpp
> +++ b/src/ipa/simple/algorithms/adjust.cpp
> @@ -124,8 +124,7 @@ void Adjust::process([[maybe_unused]] IPAContext &context,
>   	metadata.set(controls::Gamma, gamma);
> 
>   	const auto &contrast = frameContext.contrast;
> -	if (contrast)
> -		metadata.set(controls::Contrast, contrast.value());
> +	metadata.set(controls::Contrast, contrast.value_or(kDefaultContrast));
> 
>   	const auto &saturation = frameContext.saturation;
>   	metadata.set(controls::Saturation, saturation.value_or(kDefaultSaturation));
> --
> 2.52.0
>
Robert Mader Jan. 26, 2026, 3:19 p.m. UTC | #2 
Reviewed-by: Robert Mader <robert.mader@collabora.com>

On 22.01.26 17:19, Milan Zamazal wrote:
> Let's do the same with contrast as with other metadata.
>
> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
> ---
>   src/ipa/simple/algorithms/adjust.cpp | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/ipa/simple/algorithms/adjust.cpp b/src/ipa/simple/algorithms/adjust.cpp
> index 23f6f6ad7..acdd3f741 100644
> --- a/src/ipa/simple/algorithms/adjust.cpp
> +++ b/src/ipa/simple/algorithms/adjust.cpp
> @@ -124,8 +124,7 @@ void Adjust::process([[maybe_unused]] IPAContext &context,
>   	metadata.set(controls::Gamma, gamma);
>   
>   	const auto &contrast = frameContext.contrast;
> -	if (contrast)
> -		metadata.set(controls::Contrast, contrast.value());
> +	metadata.set(controls::Contrast, contrast.value_or(kDefaultContrast));
>   
>   	const auto &saturation = frameContext.saturation;
>   	metadata.set(controls::Saturation, saturation.value_or(kDefaultSaturation));

Patch
diff mbox series 

diff --git a/src/ipa/simple/algorithms/adjust.cpp b/src/ipa/simple/algorithms/adjust.cpp
index 23f6f6ad7..acdd3f741 100644
--- a/src/ipa/simple/algorithms/adjust.cpp
+++ b/src/ipa/simple/algorithms/adjust.cpp
@@ -124,8 +124,7 @@  void Adjust::process([[maybe_unused]] IPAContext &context,
 	metadata.set(controls::Gamma, gamma);
 
 	const auto &contrast = frameContext.contrast;
-	if (contrast)
-		metadata.set(controls::Contrast, contrast.value());
+	metadata.set(controls::Contrast, contrast.value_or(kDefaultContrast));
 
 	const auto &saturation = frameContext.saturation;
 	metadata.set(controls::Saturation, saturation.value_or(kDefaultSaturation));