[v2] libcamera: simple: Enable SoftISP for imx7-csi

25851 diff mbox series

Since commit "libcamera: simple: Make raw streams working" apps that rely
on raw streams - such as Millipixels - can work with the SoftISP being
enabled. Thus let's enable the later by default.

Tested on a Librem5.

Signed-off-by: Robert Mader <robert.mader@collabora.com>
---
 Documentation/isp-feature-matrix.rst     | 1 +
 src/libcamera/pipeline/simple/simple.cpp | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

Quoting Robert Mader (2026-01-19 13:13:27)
> Since commit "libcamera: simple: Make raw streams working" apps that rely
> on raw streams - such as Millipixels - can work with the SoftISP being
> enabled. Thus let's enable the later by default.
> 
> Tested on a Librem5.

As I understand it - this is a helpful thing to add now ... perhaps even
soon we'll not need the variable here at all... but that can be later.


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> 
> Signed-off-by: Robert Mader <robert.mader@collabora.com>
> ---
>  Documentation/isp-feature-matrix.rst     | 1 +
>  src/libcamera/pipeline/simple/simple.cpp | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/isp-feature-matrix.rst b/Documentation/isp-feature-matrix.rst
> index 3b101eb2f..b56f1e56e 100644
> --- a/Documentation/isp-feature-matrix.rst
> +++ b/Documentation/isp-feature-matrix.rst
> @@ -67,6 +67,7 @@ different platforms in libcamera.
>  
>     * Intel 11th-14th Gen (IPU6)
>     * Intel 15th Gen (IPU7)
> +   * NXP i.MX7 and i.MX8 series (imx7-csi)
>     * Texas Instruments J7x/AM6x
>     * Qualcomm Snapdragon (CamSS)
>  
> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> index b30b0a122..4a0b9f58d 100644
> --- a/src/libcamera/pipeline/simple/simple.cpp
> +++ b/src/libcamera/pipeline/simple/simple.cpp
> @@ -257,7 +257,7 @@ namespace {
>  
>  static const SimplePipelineInfo supportedDevices[] = {
>         { "dcmipp", {}, false },
> -       { "imx7-csi", { { "pxp", 1 } }, false },
> +       { "imx7-csi", { { "pxp", 1 } }, true },
>         { "intel-ipu6", {}, true },
>         { "intel-ipu7", {}, true },
>         { "j721e-csi2rx", {}, true },
> -- 
> 2.52.0
>

On poniedziałek, 19 stycznia 2026 14:13:27 czas środkowoeuropejski standardowy 
Robert Mader wrote:
> Since commit "libcamera: simple: Make raw streams working" apps that rely
> on raw streams - such as Millipixels - can work with the SoftISP being
> enabled. Thus let's enable the later by default.
> 
> Tested on a Librem5.

Thanks, glad to see this all coming together.

Acked-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>

> Signed-off-by: Robert Mader <robert.mader@collabora.com>
> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
>  Documentation/isp-feature-matrix.rst     | 1 +
>  src/libcamera/pipeline/simple/simple.cpp | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/isp-feature-matrix.rst
> b/Documentation/isp-feature-matrix.rst index 3b101eb2f..b56f1e56e 100644
> --- a/Documentation/isp-feature-matrix.rst
> +++ b/Documentation/isp-feature-matrix.rst
> @@ -67,6 +67,7 @@ different platforms in libcamera.
> 
>     * Intel 11th-14th Gen (IPU6)
>     * Intel 15th Gen (IPU7)
> +   * NXP i.MX7 and i.MX8 series (imx7-csi)
>     * Texas Instruments J7x/AM6x
>     * Qualcomm Snapdragon (CamSS)
> 
> diff --git a/src/libcamera/pipeline/simple/simple.cpp
> b/src/libcamera/pipeline/simple/simple.cpp index b30b0a122..4a0b9f58d
> 100644
> --- a/src/libcamera/pipeline/simple/simple.cpp
> +++ b/src/libcamera/pipeline/simple/simple.cpp
> @@ -257,7 +257,7 @@ namespace {
> 
>  static const SimplePipelineInfo supportedDevices[] = {
>  	{ "dcmipp", {}, false },
> -	{ "imx7-csi", { { "pxp", 1 } }, false },
> +	{ "imx7-csi", { { "pxp", 1 } }, true },
>  	{ "intel-ipu6", {}, true },
>  	{ "intel-ipu7", {}, true },
>  	{ "j721e-csi2rx", {}, true },

Quoting Robert Mader (2026-01-19 18:43:27)
> Since commit "libcamera: simple: Make raw streams working" apps that rely
> on raw streams - such as Millipixels - can work with the SoftISP being
> enabled. Thus let's enable the later by default.
> 
> Tested on a Librem5.
> 
> Signed-off-by: Robert Mader <robert.mader@collabora.com>

Thanks for updating the documentation as well!

Reviewed-by: Jai Luthra <jai.luthra@ideasonboard.com>

> ---
>  Documentation/isp-feature-matrix.rst     | 1 +
>  src/libcamera/pipeline/simple/simple.cpp | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/isp-feature-matrix.rst b/Documentation/isp-feature-matrix.rst
> index 3b101eb2f..b56f1e56e 100644
> --- a/Documentation/isp-feature-matrix.rst
> +++ b/Documentation/isp-feature-matrix.rst
> @@ -67,6 +67,7 @@ different platforms in libcamera.
>  
>     * Intel 11th-14th Gen (IPU6)
>     * Intel 15th Gen (IPU7)
> +   * NXP i.MX7 and i.MX8 series (imx7-csi)
>     * Texas Instruments J7x/AM6x
>     * Qualcomm Snapdragon (CamSS)
>  
> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> index b30b0a122..4a0b9f58d 100644
> --- a/src/libcamera/pipeline/simple/simple.cpp
> +++ b/src/libcamera/pipeline/simple/simple.cpp
> @@ -257,7 +257,7 @@ namespace {
>  
>  static const SimplePipelineInfo supportedDevices[] = {
>         { "dcmipp", {}, false },
> -       { "imx7-csi", { { "pxp", 1 } }, false },
> +       { "imx7-csi", { { "pxp", 1 } }, true },
>         { "intel-ipu6", {}, true },
>         { "intel-ipu7", {}, true },
>         { "j721e-csi2rx", {}, true },
> -- 
> 2.52.0
>